Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: f09a442af0074247ea9fcbf710055a0be81f2bfe
https://github.com/WebKit/WebKit/commit/f09a442af0074247ea9fcbf710055a0be81f2bfe
Author: Nikolas Zimmermann <[email protected]>
Date: 2025-11-20 (Thu, 20 Nov 2025)
Changed paths:
M Source/WebCore/platform/graphics/PlatformDisplay.h
M Source/WebCore/platform/graphics/skia/PlatformDisplaySkia.cpp
M Source/WebCore/platform/graphics/skia/SkiaPaintingEngine.cpp
M
Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedBackingStoreProxy.cpp
M Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.cpp
Log Message:
-----------
[GTK][WPE] Check for valid GL context before attempting GPU rendering
https://bugs.webkit.org/show_bug.cgi?id=302857
Reviewed by Carlos Garcia Campos.
Some places were checking ProcessCapabilities::canUseAcceleratedBuffers() but
not verifying that a GL context is actually available. This could lead to
issues when GPU rendering is attempted without a valid context. Now consistently
checking both conditions across SkiaPaintingEngine, CoordinatedBackingStoreProxy
and LayerTreeHost.
Covered by existing tests.
* Source/WebCore/platform/graphics/PlatformDisplay.h:
* Source/WebCore/platform/graphics/skia/PlatformDisplaySkia.cpp:
(WebCore::PlatformDisplay::skiaGrContext const):
(WebCore::PlatformDisplay::skiaGrContext): Deleted.
* Source/WebCore/platform/graphics/skia/SkiaPaintingEngine.cpp:
(WebCore::canPerformAcceleratedRendering):
(WebCore::SkiaPaintingEngine::SkiaPaintingEngine):
(WebCore::SkiaPaintingEngine::numberOfGPUPaintingThreads):
*
Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedBackingStoreProxy.cpp:
(WebCore::CoordinatedBackingStoreProxy::computeTileSize const):
(WebCore::CoordinatedBackingStoreProxy::adjustForContentsRect const): Deleted.
(WebCore::CoordinatedBackingStoreProxy::computeCoverAndKeepRect const): Deleted.
(WebCore::CoordinatedBackingStoreProxy::takePendingUpdate): Deleted.
(WebCore::CoordinatedBackingStoreProxy::mapToContents const): Deleted.
(WebCore::CoordinatedBackingStoreProxy::mapFromContents const): Deleted.
(WebCore::CoordinatedBackingStoreProxy::tileRectForPosition const): Deleted.
(WebCore::CoordinatedBackingStoreProxy::tilePositionForPoint const): Deleted.
(WebCore::CoordinatedBackingStoreProxy::forEachTilePositionInRect): Deleted.
(WebCore::CoordinatedBackingStoreProxy::waitUntilPaintingComplete): Deleted.
* Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.cpp:
(WebKit::LayerTreeHost::fillGLInformation):
Canonical link: https://commits.webkit.org/303339@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
