Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1e0722c5382faf5a54606611970bbe92b9a1e2d5
      
https://github.com/WebKit/WebKit/commit/1e0722c5382faf5a54606611970bbe92b9a1e2d5
  Author: Devin Rousso <[email protected]>
  Date:   2025-11-20 (Thu, 20 Nov 2025)

  Changed paths:
    M Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
    A Source/WebInspectorUI/UserInterface/Images/Dominator.svg
    M 
Source/WebInspectorUI/UserInterface/Views/HeapSnapshotInstanceDataGridNode.js
    M 
Source/WebInspectorUI/UserInterface/Views/HeapSnapshotInstancesContentView.css

  Log Message:
  -----------
  Web Inspector: Timelines: Heap: show the dominator (if any) when viewing the 
shortest GC path
https://bugs.webkit.org/show_bug.cgi?id=302837

Reviewed by BJ Burg.

JS heap snapshots already have enough data to determine if there's a single 
dominator for a given object.

Web Inspector should expose this information for developers that are trying to 
leverage it.

* Source/WebInspectorUI/UserInterface/Views/HeapSnapshotInstanceDataGridNode.js:
(WI.HeapSnapshotInstanceDataGridNode.prototype._mouseoverHandler):
(WI.HeapSnapshotInstanceDataGridNode.prototype._mouseoverHandler.appendPath):
(WI.HeapSnapshotInstanceDataGridNode.prototype._mouseoverHandler.appendPathRow):
* 
Source/WebInspectorUI/UserInterface/Views/HeapSnapshotInstancesContentView.css:
(.heap-snapshot-instance-popover-content td.dominator > .glyph): Added.
(.heap-snapshot-instance-popover-content td.dominated::before): Added.
(@media (prefers-color-scheme: dark) .heap-snapshot-instance-popover-content 
td.dominator > .glyph): Added.

* Source/WebInspectorUI/UserInterface/Images/Dominator.svg: Added.
* Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:

Canonical link: https://commits.webkit.org/303368@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications

Reply via email to