Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: fc9b2b2ae777519d8dcaa78e5e8e252b5f36c458
https://github.com/WebKit/WebKit/commit/fc9b2b2ae777519d8dcaa78e5e8e252b5f36c458
Author: Antoine Quint <[email protected]>
Date: 2025-11-21 (Fri, 21 Nov 2025)
Changed paths:
A
LayoutTests/webanimations/threaded-animations/pending-animation-crash-expected.txt
A LayoutTests/webanimations/threaded-animations/pending-animation-crash.html
M Source/WebCore/animation/KeyframeEffect.cpp
Log Message:
-----------
[threaded-animations]
https://scroll-driven-animations.style/demos/scroll-shadows/css/ asserts with
"Threaded Scroll-driven Animations" enabled
https://bugs.webkit.org/show_bug.cgi?id=302953
Reviewed by Alan Baradlay.
We made a mistake in 303312@main and removed the requirement that an effect's
associated animation not be pending to qualify for acceleration and as a result
we hit the `ASSERT(!animation->pending())` assertion in the `AcceleratedEffect`
constructor.
We simply reinstate this requirement in `KeyframeEffect::canBeAccelerated()`
for threaded animations.
Test: webanimations/threaded-animations/pending-animation-crash.html
*
LayoutTests/webanimations/threaded-animations/pending-animation-crash-expected.txt:
Added.
* LayoutTests/webanimations/threaded-animations/pending-animation-crash.html:
Added.
* Source/WebCore/animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::canBeAccelerated const):
Canonical link: https://commits.webkit.org/303410@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
