Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 85b8b03d430589e9a39c93e69983ef393e17fc8a
https://github.com/WebKit/WebKit/commit/85b8b03d430589e9a39c93e69983ef393e17fc8a
Author: Adrian Taylor <[email protected]>
Date: 2025-11-23 (Sun, 23 Nov 2025)
Changed paths:
M Source/WebKit/Platform/IPC/Connection.h
M Source/WebKit/Shared/API/APIArray.h
M Source/WebKit/Shared/API/APIObject.h
M Source/WebKit/Shared/SessionState.h
M Source/WebKit/Shared/WebBackForwardListFrameItem.h
M Source/WebKit/Shared/WebBackForwardListItem.h
M Source/WebKit/UIProcess/AuxiliaryProcessProxy.h
M Source/WebKit/UIProcess/WebBackForwardCache.h
M Source/WebKit/UIProcess/WebFrameProxy.h
M Source/WebKit/UIProcess/WebPageProxy.h
M Source/WebKit/UIProcess/WebPreferences.h
M Source/WebKit/UIProcess/WebProcessProxy.h
M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h
M Tools/TestWebKitAPI/Configurations/Base.xcconfig
Log Message:
-----------
Ref count various WebKit types within Swift
https://bugs.webkit.org/show_bug.cgi?id=302644
rdar://164888628
Reviewed by Geoffrey Garen.
This informs Swift that some C++ types should be treated as Swift reference
types (i.e. reference-counted) rather than value types. It teaches Swift
how to manipulate the reference counts for these types.
This is a temporary solution. In due course, we'll be able to inform
Swift that the base WTF::RefCounted type is the ancestor of all reference
counted types, and it won't be necessary to make these changes to
individual classes.
That's enabled by either of these changes:
rdar://131065240 - allow templated types to be ref counted
rdar://160696723 - allow method calls for ref and deref
We can't currently use this functionality in WebKit because we need
to support older compilers, and also due to a compiler
bug rdar://162195228. So for now, we will annotate just those
specific types which are required for upcoming CoreIPC message handler
work.
To avoid warnings/errors, these functions need to have their parameters
marked as _Nonnull, or specifically to adopt the WTF macro WTF_NONNULL.
That currently causes problems with -Wnullability-completeness, which
complains that other functions in the same headers are not duly
annotated. WebKit has switched off this warning for its whole codebase
but had overlooked TestWebKitAPI, which does not inherit warning flags
from the rest of the .xcconfig system. Add this warning flag there too
in order to prevent these compile errors when TestWebKitAPI indirectly
includes IPC/Connection.h
Canonical link: https://commits.webkit.org/303461@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
