Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 5a5eb476f8e3720154ebe8afcca64b4da436db3c
https://github.com/WebKit/WebKit/commit/5a5eb476f8e3720154ebe8afcca64b4da436db3c
Author: Michael Catanzaro <[email protected]>
Date: 2025-11-24 (Mon, 24 Nov 2025)
Changed paths:
M Source/WebKit/UIProcess/API/gtk/DropTargetGtk4.cpp
Log Message:
-----------
[GTK] gdk_drop_status: assertion 'priv->state != GDK_DROP_STATE_FINISHED'
failed
https://bugs.webkit.org/show_bug.cgi?id=299208
Reviewed by Carlos Garcia Campos.
It is an error to call gdk_drop_status() after gdk_drop_finish(). But
we do it 100% of the time after dragging a folder from nautilus into the
web view. It also happens under Flatpak when dragging HTML elements
within web content. We wind up in DropTarget::didPerformAction after
drag enter, motion, or, critically, exit. But we only want to actually
update the drag status after enter or motion.
Additionally, this function is called *asynchronously* after the drag
event, so it could get called too late even if triggered by an enter or
motion event.
Canonical link: https://commits.webkit.org/303500@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
