Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: a978fae61986c0d3056e523f6552f28fc7b19b9f
https://github.com/WebKit/WebKit/commit/a978fae61986c0d3056e523f6552f28fc7b19b9f
Author: Geoffrey Garen <[email protected]>
Date: 2025-11-25 (Tue, 25 Nov 2025)
Changed paths:
M Source/JavaScriptCore/bytecode/Watchpoint.cpp
M Source/JavaScriptCore/inspector/remote/cocoa/RemoteInspectorCocoa.mm
M
Source/JavaScriptCore/inspector/remote/cocoa/RemoteInspectorXPCConnection.h
M Source/WTF/WTF.xcodeproj/project.pbxproj
M Source/WTF/wtf/CMakeLists.txt
M Source/WTF/wtf/Platform.h
A Source/WTF/wtf/RefCountDebugger.cpp
A Source/WTF/wtf/RefCountDebugger.h
R Source/WTF/wtf/RefCounted.cpp
M Source/WTF/wtf/RefCounted.h
M Source/WTF/wtf/ThreadSafeRefCounted.h
M Source/WTF/wtf/ThreadSafeRefCountedWithSuppressingSaferCPPChecking.h
M Source/WebCore/css/StyleRule.h
M Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp
M Source/WebKit/UIProcess/wpe/AcceleratedBackingStore.cpp
Log Message:
-----------
Factor refcount debugging code into a separate base class
https://bugs.webkit.org/show_bug.cgi?id=303029
rdar://165313018
Reviewed by Chris Dumez.
Created a new base class, RefCountDebugger, to hold debug-only code. Moved
debug-only refcounting code into it.
This makes the refcounting logic more visible, removes a bunch of duplicate
code, and makes it easier to add a new refcounting class -- which I plan to do
soon.
Anything you're not testing is broken, so adding adoption assertions to
ThreadSafeRefCounted<T> uncovered some non-conforming code. I added
relaxAdoptionRequirement() to the ThreadSafeRefCounted<T> constructor to
maintain the status quo for now -- but we should really go back and fix this.
I added a create() function to RemoteInspectorXPCConnection before I gave up on
fixing adoption assertions, so I've kept that in the patch.
Canonical link: https://commits.webkit.org/303536@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
