Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 084d2466a8fe59f2fb5dad438f09e12cb7721f07
https://github.com/WebKit/WebKit/commit/084d2466a8fe59f2fb5dad438f09e12cb7721f07
Author: Diego Pino Garcia <[email protected]>
Date: 2025-11-26 (Wed, 26 Nov 2025)
Changed paths:
M Tools/CISupport/build-webkit-org/config.json
M Tools/CISupport/build-webkit-org/factories_unittest.py
M Tools/CISupport/ews-app/ews/common/github.py
M Tools/CISupport/ews-app/ews/views/statusbubble.py
M Tools/CISupport/ews-build/config.json
M Tools/CISupport/ews-build/factories.py
M Tools/CISupport/ews-build/factories_unittest.py
M Tools/CISupport/ews-build/loadConfig.py
M Tools/CISupport/ews-build/steps.py
M Tools/CISupport/ews-build/steps_unittest.py
Log Message:
-----------
[WKCI] Make WPE-Cairo bot build with LibWebRTC
https://bugs.webkit.org/show_bug.cgi?id=303088
Reviewed by Carlos Alberto Lopez Perez.
Changeset 300680@main, added '--cmakeargs=-DUSE_GSTREAMER_WEBRTC=FALSE' to the
'additionalArguments' array of 'WPE-Cairo-Build-EWS'. However, this extra
argument was never passed to the bot because since 263387@main is necessary
that 'additionalArguments' are also added to 'VALID_ADDITIONAL_ARGUMENTS_LIST'
for builder bots in order to be applied.
Since we can control CMake flags at bot configuration level, we've opted
for never use 'additionalArguments' for build flags.
Also, rename 'wpe-cairo' to 'wpe-cairo-libwebrtc'.
* Tools/CISupport/build-webkit-org/config.json:
* Tools/CISupport/build-webkit-org/factories_unittest.py:
* Tools/CISupport/ews-app/ews/common/github.py:
* Tools/CISupport/ews-app/ews/views/statusbubble.py:
* Tools/CISupport/ews-build/config.json:
* Tools/CISupport/ews-build/factories.py:
* Tools/CISupport/ews-build/factories_unittest.py:
* Tools/CISupport/ews-build/loadConfig.py:
* Tools/CISupport/ews-build/steps.py:
* Tools/CISupport/ews-build/steps_unittest.py:
Canonical link: https://commits.webkit.org/303565@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
