Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: b59b7d45815ea9c0532af8ae529053c61da1abe4
https://github.com/WebKit/WebKit/commit/b59b7d45815ea9c0532af8ae529053c61da1abe4
Author: Sam Weinig <[email protected]>
Date: 2025-11-26 (Wed, 26 Nov 2025)
Changed paths:
M Source/WebCore/Headers.cmake
M Source/WebCore/Sources.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/css/CSSPrimitiveValueMappings.h
M Source/WebCore/css/CSSProperties.json
M Source/WebCore/css/scripts/process-css-properties.py
M Source/WebCore/page/LocalFrameView.cpp
M Source/WebCore/rendering/RenderBox.cpp
M Source/WebCore/rendering/RenderLayerScrollableArea.cpp
M Source/WebCore/rendering/RenderReplaced.cpp
M Source/WebCore/rendering/RenderTextControl.cpp
M Source/WebCore/rendering/style/RenderStyle.cpp
M Source/WebCore/rendering/style/RenderStyle.h
M Source/WebCore/rendering/style/RenderStyleInlines.h
M Source/WebCore/rendering/style/RenderStyleSetters.h
M Source/WebCore/rendering/style/SVGRenderStyle.cpp
M Source/WebCore/rendering/style/SVGRenderStyleDefs.cpp
M Source/WebCore/rendering/style/SVGRenderStyleDefs.h
M Source/WebCore/rendering/style/StyleAppleColorFilterData.h
A Source/WebCore/rendering/style/StyleBackdropFilterData.cpp
A Source/WebCore/rendering/style/StyleBackdropFilterData.h
M Source/WebCore/rendering/style/StyleBackgroundData.cpp
M Source/WebCore/rendering/style/StyleBackgroundData.h
M Source/WebCore/rendering/style/StyleBoxData.cpp
M Source/WebCore/rendering/style/StyleBoxData.h
M Source/WebCore/rendering/style/StyleDeprecatedFlexibleBoxData.cpp
M Source/WebCore/rendering/style/StyleDeprecatedFlexibleBoxData.h
M Source/WebCore/rendering/style/StyleFilterData.h
M Source/WebCore/rendering/style/StyleGridData.cpp
M Source/WebCore/rendering/style/StyleGridData.h
M Source/WebCore/rendering/style/StyleGridItemData.cpp
M Source/WebCore/rendering/style/StyleGridItemData.h
M Source/WebCore/rendering/style/StyleMarqueeData.cpp
M Source/WebCore/rendering/style/StyleMarqueeData.h
M Source/WebCore/rendering/style/StyleMultiColData.cpp
M Source/WebCore/rendering/style/StyleMultiColData.h
M Source/WebCore/rendering/style/StyleRareInheritedData.cpp
M Source/WebCore/rendering/style/StyleRareInheritedData.h
M Source/WebCore/rendering/style/StyleRareNonInheritedData.cpp
M Source/WebCore/rendering/style/StyleRareNonInheritedData.h
M Source/WebCore/rendering/style/StyleTransformData.cpp
M Source/WebCore/rendering/style/StyleTransformData.h
M Source/WebCore/style/StyleAdjuster.cpp
M Source/WebCore/style/values/scrollbars/StyleScrollbarWidth.cpp
M Source/WebCore/style/values/scrollbars/StyleScrollbarWidth.h
M Source/WebKitLegacy/mac/WebView/WebHTMLView.mm
Log Message:
-----------
[RenderStyleGen] Extend getter/setter generation to all non-special cased
properties
https://bugs.webkit.org/show_bug.cgi?id=303151
Reviewed by Darin Adler.
Extends RenderStyle getter/setter function implementation generation
to all properties except ones that still need additional special casing.
The remaining special cases are:
- properties that use fromRaw/toRaw conversions (e.g. `hanging-punctuation`)
- properties that have setters that set multiple values (e.g. `appearance`)
- properties that don't have a single strong style type representing them
(e.g. `caret-color`)
- properties that have a getter name that doesn't match the setter name
(e.g. `computedWordSpacing` / `setWordSpacing`)
- properties that are not stored directly in a data class, but rather
within a struct (e.g. `border-bottom-color`)
- @page descriptors (e.g. `page-size`)
A few changes were need to conform all the properties that are being generated
including:
- update the names of storage members to match the property name.
- adding a data class for `backdrop-filter` to ensure we can have a
matching storage member name.
- converting `Style::ScrollbarWidth` from a struct to an enum, and using a
ToPlatform interface
to implement the platform conversion.
- Updating the signatures of getters/setters in RenderStyle to match
conventions
Additionally, a few member functions of RenderStyle were easily removable:
- aspectRatioWidth()/aspectRatioHeight() were replaced by
aspectRatio().width()/aspectRatio().height()
- clearAnimations()/clearTransitions() were unused.
* Source/WebCore/Headers.cmake:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/css/CSSPrimitiveValueMappings.h:
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/css/scripts/process-css-properties.py:
* Source/WebCore/page/LocalFrameView.cpp:
* Source/WebCore/rendering/RenderBox.cpp:
* Source/WebCore/rendering/RenderLayerScrollableArea.cpp:
* Source/WebCore/rendering/RenderReplaced.cpp:
* Source/WebCore/rendering/RenderTextControl.cpp:
* Source/WebCore/rendering/style/RenderStyle.cpp:
* Source/WebCore/rendering/style/RenderStyle.h:
* Source/WebCore/rendering/style/RenderStyleInlines.h:
* Source/WebCore/rendering/style/RenderStyleSetters.h:
* Source/WebCore/rendering/style/SVGRenderStyle.cpp:
* Source/WebCore/rendering/style/SVGRenderStyleDefs.cpp:
* Source/WebCore/rendering/style/SVGRenderStyleDefs.h:
* Source/WebCore/rendering/style/StyleBackdropFilterData.cpp: Added.
* Source/WebCore/rendering/style/StyleBackdropFilterData.h: Added.
* Source/WebCore/rendering/style/StyleBackgroundData.cpp:
* Source/WebCore/rendering/style/StyleBackgroundData.h:
* Source/WebCore/rendering/style/StyleBoxData.cpp:
* Source/WebCore/rendering/style/StyleBoxData.h:
* Source/WebCore/rendering/style/StyleDeprecatedFlexibleBoxData.cpp:
* Source/WebCore/rendering/style/StyleDeprecatedFlexibleBoxData.h:
* Source/WebCore/rendering/style/StyleGridData.cpp:
* Source/WebCore/rendering/style/StyleGridData.h:
* Source/WebCore/rendering/style/StyleGridItemData.cpp:
* Source/WebCore/rendering/style/StyleGridItemData.h:
* Source/WebCore/rendering/style/StyleMarqueeData.cpp:
* Source/WebCore/rendering/style/StyleMarqueeData.h:
* Source/WebCore/rendering/style/StyleMultiColData.cpp:
* Source/WebCore/rendering/style/StyleMultiColData.h:
* Source/WebCore/rendering/style/StyleRareInheritedData.cpp:
* Source/WebCore/rendering/style/StyleRareInheritedData.h:
* Source/WebCore/rendering/style/StyleRareNonInheritedData.cpp:
* Source/WebCore/rendering/style/StyleRareNonInheritedData.h:
* Source/WebCore/rendering/style/StyleTransformData.cpp:
* Source/WebCore/rendering/style/StyleTransformData.h:
* Source/WebCore/style/StyleAdjuster.cpp:
* Source/WebCore/style/values/scrollbars/StyleScrollbarWidth.cpp:
* Source/WebCore/style/values/scrollbars/StyleScrollbarWidth.h:
* Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:
Canonical link: https://commits.webkit.org/303585@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
