[webkit-changes] [WebKit/WebKit] 8562be: Move focus ring code to OutlinePainter

Tue, 02 Dec 2025 12:38:23 -0800 

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8562be651f6b2ce9d5cf4ed9b8bed1c45c821c37
      
https://github.com/WebKit/WebKit/commit/8562be651f6b2ce9d5cf4ed9b8bed1c45c821c37
  Author: Antti Koivisto <[email protected]>
  Date:   2025-11-27 (Thu, 27 Nov 2025)

  Changed paths:
    M Source/WebCore/rendering/BorderPainter.cpp
    M Source/WebCore/rendering/OutlinePainter.cpp
    M Source/WebCore/rendering/OutlinePainter.h
    M Source/WebCore/rendering/RenderBlock.cpp
    M Source/WebCore/rendering/RenderBlock.h
    M Source/WebCore/rendering/RenderBlockFlow.cpp
    M Source/WebCore/rendering/RenderBlockFlow.h
    M Source/WebCore/rendering/RenderBox.cpp
    M Source/WebCore/rendering/RenderBox.h
    M Source/WebCore/rendering/RenderElement.cpp
    M Source/WebCore/rendering/RenderElement.h
    M Source/WebCore/rendering/RenderInline.cpp
    M Source/WebCore/rendering/RenderInline.h
    M Source/WebCore/rendering/RenderListBox.cpp
    M Source/WebCore/rendering/RenderListBox.h
    M Source/WebCore/rendering/RenderObject.cpp
    M Source/WebCore/rendering/RenderObject.h
    M Source/WebCore/rendering/RenderTextControl.cpp
    M Source/WebCore/rendering/RenderTextControl.h
    M Source/WebCore/rendering/svg/RenderSVGModelObject.h
    M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGModelObject.cpp
    M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGModelObject.h

  Log Message:
  -----------
  Move focus ring code to OutlinePainter
https://bugs.webkit.org/show_bug.cgi?id=303168
rdar://165474109

Reviewed by Alan Baradlay.

Move more code out of RenderObjects.

* Source/WebCore/rendering/BorderPainter.cpp:
* Source/WebCore/rendering/OutlinePainter.cpp:
(WebCore::OutlinePainter::paintOutline const):
(WebCore::usePlatformFocusRingColorForOutlineStyleAuto):
(WebCore::useShrinkWrappedFocusRingForOutlineStyleAuto):
(WebCore::drawFocusRing):
(WebCore::OutlinePainter::paintFocusRing const):
(WebCore::OutlinePainter::collectFocusRingRects):
(WebCore::OutlinePainter::collectFocusRingRectsForListBox):
(WebCore::OutlinePainter::collectFocusRingRectsForInline):
(WebCore::OutlinePainter::collectFocusRingRectsForBlock):
(WebCore::OutlinePainter::collectFocusRingRectsForChildBox):
(WebCore::OutlinePainter::collectFocusRingRectsForInlineChildren):
(WebCore::OutlinePainter::deviceScaleFactor const):
* Source/WebCore/rendering/OutlinePainter.h:
* Source/WebCore/rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addFocusRingRectsForInlineChildren const): Deleted.
(WebCore::RenderBlock::addFocusRingRects const): Deleted.
(WebCore::RenderBlock::addFocusRingRectsForBlockChild const): Deleted.
* Source/WebCore/rendering/RenderBlock.h:
* Source/WebCore/rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::addFocusRingRectsForInlineChildren const): Deleted.
* Source/WebCore/rendering/RenderBlockFlow.h:
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::addFocusRingRects const): Deleted.
* Source/WebCore/rendering/RenderBox.h:
* Source/WebCore/rendering/RenderElement.cpp:
(WebCore::RenderElement::issueRepaintForOutlineAuto):
(WebCore::usePlatformFocusRingColorForOutlineStyleAuto): Deleted.
(WebCore::useShrinkWrappedFocusRingForOutlineStyleAuto): Deleted.
(WebCore::drawFocusRing): Deleted.
(WebCore::RenderElement::paintFocusRing const): Deleted.
* Source/WebCore/rendering/RenderElement.h:
(WebCore::RenderElement::paintRectToClipOutFromBorder):
* Source/WebCore/rendering/RenderInline.cpp:
(WebCore::RenderInline::collectLineBoxRects const):
(WebCore::RenderInline::paintOutline const):
(WebCore::RenderInline::addFocusRingRects const): Deleted.
* Source/WebCore/rendering/RenderInline.h:
* Source/WebCore/rendering/RenderListBox.cpp:
(WebCore::RenderListBox::addFocusRingRects const): Deleted.
* Source/WebCore/rendering/RenderListBox.h:
* Source/WebCore/rendering/RenderObject.cpp:
(WebCore::RenderObject::addPDFURLRect const):
(WebCore::RenderObject::absoluteFocusRingQuads):
* Source/WebCore/rendering/RenderObject.h:
(WebCore::RenderObject::addFocusRingRects const): Deleted.
* Source/WebCore/rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::addFocusRingRects const): Deleted.
* Source/WebCore/rendering/RenderTextControl.h:
* Source/WebCore/rendering/svg/RenderSVGModelObject.h:
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGModelObject.cpp:
(WebCore::LegacyRenderSVGModelObject::addFocusRingRects const):
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGModelObject.h:

Canonical link: https://commits.webkit.org/303606@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications

Reply via email to