Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 0c009bd3041dcffddadd9656a928076ba262462f
https://github.com/WebKit/WebKit/commit/0c009bd3041dcffddadd9656a928076ba262462f
Author: Etienne Segonzac <[email protected]>
Date: 2025-11-27 (Thu, 27 Nov 2025)
Changed paths:
M LayoutTests/interaction-region/guard-crash-expected.txt
M LayoutTests/interaction-region/guard-crash.html
M LayoutTests/interaction-region/interaction-layers-culling-expected.txt
M
LayoutTests/interaction-region/interaction-layers-culling-layer-type-change-expected.txt
M
LayoutTests/interaction-region/interaction-layers-culling-layer-type-change.html
M LayoutTests/interaction-region/interaction-layers-culling.html
M LayoutTests/interaction-region/layer-tree-expected.txt
M LayoutTests/interaction-region/layer-tree-shape-reset-expected.txt
M LayoutTests/interaction-region/layer-tree-shape-reset.html
M LayoutTests/interaction-region/layer-tree.html
M LayoutTests/platform/visionos/TestExpectations
M LayoutTests/platform/visionos/transforms/separated-expected.txt
M
LayoutTests/platform/visionos/transforms/separated-image-animated-expected.txt
M LayoutTests/platform/visionos/transforms/separated-image-animated.html
M
LayoutTests/platform/visionos/transforms/separated-image-downgrade-content-expected.txt
M
LayoutTests/platform/visionos/transforms/separated-image-downgrade-content.html
M
LayoutTests/platform/visionos/transforms/separated-image-downgrade-expected.txt
M
LayoutTests/platform/visionos/transforms/separated-image-downgrade-tiled-expected.txt
M
LayoutTests/platform/visionos/transforms/separated-image-downgrade-tiled.html
M LayoutTests/platform/visionos/transforms/separated-image-downgrade.html
M
LayoutTests/platform/visionos/transforms/separated-image-upgrade-expected.txt
M
LayoutTests/platform/visionos/transforms/separated-image-upgrade-tiled-expected.txt
M
LayoutTests/platform/visionos/transforms/separated-image-upgrade-tiled.html
M LayoutTests/platform/visionos/transforms/separated-image-upgrade.html
M LayoutTests/platform/visionos/transforms/separated-update-expected.txt
M LayoutTests/platform/visionos/transforms/separated-update.html
M LayoutTests/platform/visionos/transforms/separated-video-expected.txt
M LayoutTests/platform/visionos/transforms/separated-video.html
M LayoutTests/platform/visionos/transforms/separated.html
M LayoutTests/resources/ui-helper.js
M Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivateForTesting.h
M Source/WebKit/UIProcess/API/Cocoa/WKWebViewTesting.mm
M Source/WebKit/UIProcess/API/ios/WKWebViewPrivateForTestingIOS.h
M Source/WebKit/UIProcess/API/ios/WKWebViewTestingIOS.mm
M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.h
M
Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeDrawingAreaProxyIOS.h
M
Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeDrawingAreaProxyIOS.mm
M Tools/TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl
M Tools/TestRunnerShared/UIScriptContext/UIScriptController.h
M Tools/WebKitTestRunner/cocoa/UIScriptControllerCocoa.h
M Tools/WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm
M Tools/WebKitTestRunner/ios/UIScriptControllerIOS.h
M Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm
Log Message:
-----------
[visionOS] Re-enable CALayer/UIView Tree based tests and make them more
reliable
https://bugs.webkit.org/show_bug.cgi?id=303110
<rdar://165410344>
Reviewed by Mike Wyrzykowski.
Introduce new test-only helper to get the text representation of a
CALayer or UIView subtree. This makes the tests much more focused and
easier to maintain, since they don't pick-up unrelated changes.
The methods are called `UIHelper.getUIViewTreeForCompositedElement()`
and `UIHelper.getCALayerTreeForCompositedElement()` to make it clear
that the element needs its own layer for this to work.
* LayoutTests/interaction-region/guard-crash-expected.txt:
* LayoutTests/interaction-region/guard-crash.html:
* LayoutTests/interaction-region/interaction-layers-culling-expected.txt:
*
LayoutTests/interaction-region/interaction-layers-culling-layer-type-change-expected.txt:
*
LayoutTests/interaction-region/interaction-layers-culling-layer-type-change.html:
* LayoutTests/interaction-region/interaction-layers-culling.html:
* LayoutTests/interaction-region/layer-tree-expected.txt:
* LayoutTests/interaction-region/layer-tree-shape-reset-expected.txt:
* LayoutTests/interaction-region/layer-tree-shape-reset.html:
* LayoutTests/interaction-region/layer-tree.html:
Update the interaction-region CALayer tree based test to use the new
method, focused on the #test element.
* LayoutTests/platform/visionos/TestExpectations:
Re-enabled the tests.
* LayoutTests/platform/visionos/transforms/separated-expected.txt:
*
LayoutTests/platform/visionos/transforms/separated-image-animated-expected.txt:
* LayoutTests/platform/visionos/transforms/separated-image-animated.html:
*
LayoutTests/platform/visionos/transforms/separated-image-downgrade-content-expected.txt:
*
LayoutTests/platform/visionos/transforms/separated-image-downgrade-content.html:
*
LayoutTests/platform/visionos/transforms/separated-image-downgrade-expected.txt:
*
LayoutTests/platform/visionos/transforms/separated-image-downgrade-tiled-expected.txt:
* LayoutTests/platform/visionos/transforms/separated-image-downgrade-tiled.html:
* LayoutTests/platform/visionos/transforms/separated-image-downgrade.html:
* LayoutTests/platform/visionos/transforms/separated-image-upgrade-expected.txt:
*
LayoutTests/platform/visionos/transforms/separated-image-upgrade-tiled-expected.txt:
* LayoutTests/platform/visionos/transforms/separated-image-upgrade-tiled.html:
* LayoutTests/platform/visionos/transforms/separated-image-upgrade.html:
* LayoutTests/platform/visionos/transforms/separated-update-expected.txt:
* LayoutTests/platform/visionos/transforms/separated-update.html:
* LayoutTests/platform/visionos/transforms/separated-video-expected.txt:
* LayoutTests/platform/visionos/transforms/separated-video.html:
* LayoutTests/platform/visionos/transforms/separated.html:
Update the transforms UIView/CALayer tree based test to use the new
method, focused on the #test element.
* LayoutTests/resources/ui-helper.js:
(window.UIHelper.getUIViewTreeForCompositedElement):
(window.UIHelper.getCALayerTreeForCompositedElement):
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivateForTesting.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewTesting.mm:
(-[WKWebView _caLayerTreeAsTextForLayerWithID:]):
(-[WKWebView _caLayerTreeAsTextForLayer:]):
(-[WKWebView _caLayerTreeAsText]):
* Source/WebKit/UIProcess/API/ios/WKWebViewPrivateForTestingIOS.h:
* Source/WebKit/UIProcess/API/ios/WKWebViewTestingIOS.mm:
(dumpUIView):
(-[WKWebView _uiViewTreeAsText]):
(-[WKWebView _uiViewTreeAsTextForViewWithLayerID:]):
(-[WKWebView _uiViewTreeAsTextForView:]):
* Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.h:
Make the `m_remoteLayerTreeHost` protected instead of private for the
test-only method in `RemoteLayerTreeDrawingAreaProxyIOS`.
*
Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeDrawingAreaProxyIOS.h:
*
Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeDrawingAreaProxyIOS.mm:
(WebKit::RemoteLayerTreeDrawingAreaProxyIOS::viewWithLayerIDForTesting const):
* Tools/TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
* Tools/TestRunnerShared/UIScriptContext/UIScriptController.h:
(WTR::UIScriptController::caLayerTreeAsTextForLayerWithID const):
(WTR::UIScriptController::uiViewTreeAsTextForViewWithLayerID const):
* Tools/WebKitTestRunner/cocoa/UIScriptControllerCocoa.h:
* Tools/WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm:
(WTR::UIScriptControllerCocoa::caLayerTreeAsTextForLayerWithID const):
* Tools/WebKitTestRunner/ios/UIScriptControllerIOS.h:
* Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:
(WTR::UIScriptControllerIOS::uiViewTreeAsTextForViewWithLayerID const):
Add new test-only methods to get the text representation of a CALayer or
UIView subtree based on a Platform Layer ID.
Canonical link: https://commits.webkit.org/303600@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
