Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 12fa34cb62cfab5e9933be77ac4a3a0f984606c8
https://github.com/WebKit/WebKit/commit/12fa34cb62cfab5e9933be77ac4a3a0f984606c8
Author: Phinehas Fuachie <[email protected]>
Date: 2025-12-01 (Mon, 01 Dec 2025)
Changed paths:
M Source/WebCore/platform/cocoa/VideoPresentationModel.h
M Source/WebCore/platform/cocoa/WebAVPlayerLayer.h
M Source/WebCore/platform/cocoa/WebAVPlayerLayer.mm
M Source/WebKit/UIProcess/Cocoa/VideoPresentationManagerProxy.h
M Source/WebKit/UIProcess/Cocoa/VideoPresentationManagerProxy.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/UI/VideoPresentationMode.mm
Log Message:
-----------
Add WebAVPlayerLayer caption preview API mocking for AVKit coordination
https://bugs.webkit.org/show_bug.cgi?id=302774
rdar://164426429
Reviewed by Jer Noble.
WebKit needs to mock new AVPlayerLayer APIs to support FCC subtitles caption
preview functionality.
AVKit calls these APIs during caption preview, and WebKit must coordinate by
hiding/showing its own
caption layer appropriately.
Establish clean architecture where caption preview requests flow through
VideoPresentationManagerProxy → WebPageProxy → IPC → MediaControlsHost,
ensuring proper process
separation and following WebKit's established cross-process communication
patterns.
Test: Tools/TestWebKitAPI/Tests/WebKitCocoa/UI/VideoPresentationMode.mm
* Source/WebCore/platform/cocoa/VideoPresentationModel.h:
(WebCore::VideoPresentationModel::requestShowCaptionDisplaySettingsPreview):
(WebCore::VideoPresentationModel::requestHideCaptionDisplaySettingsPreview):
* Source/WebCore/platform/cocoa/WebAVPlayerLayer.h:
* Source/WebCore/platform/cocoa/WebAVPlayerLayer.mm:
(-[WebAVPlayerLayer init]):
(-[WebAVPlayerLayer showingCaptionPreview]):
(-[WebAVPlayerLayer setCaptionPreviewProfileID:position:text:]):
(-[WebAVPlayerLayer stopShowingCaptionPreview]):
* Source/WebKit/UIProcess/Cocoa/VideoPresentationManagerProxy.h:
* Source/WebKit/UIProcess/Cocoa/VideoPresentationManagerProxy.mm:
(WebKit::VideoPresentationModelContext::requestShowCaptionDisplaySettingsPreview):
(WebKit::VideoPresentationModelContext::requestHideCaptionDisplaySettingsPreview):
(WebKit::VideoPresentationManagerProxy::performCaptionDisplaySettingsAction):
(WebKit::VideoPresentationManagerProxy::requestShowCaptionDisplaySettingsPreview):
(WebKit::VideoPresentationManagerProxy::requestHideCaptionDisplaySettingsPreview):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/UI/VideoPresentationMode.mm:
(TEST(VideoPresentationMode, CaptionPreview)):
Canonical link: https://commits.webkit.org/303684@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
