Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: b7a21d91ed7997f9ddac8ae0ce9e5d72cdb4c07f
https://github.com/WebKit/WebKit/commit/b7a21d91ed7997f9ddac8ae0ce9e5d72cdb4c07f
Author: Sam Weinig <[email protected]>
Date: 2025-12-05 (Fri, 05 Dec 2025)
Changed paths:
M Source/WebCore/CMakeLists.txt
M Source/WebCore/DerivedSources.make
M Source/WebCore/Headers.cmake
M Source/WebCore/SaferCPPExpectations/UncheckedCallArgsCheckerExpectations
M Source/WebCore/SaferCPPExpectations/UncheckedLocalVarsCheckerExpectations
M Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
M Source/WebCore/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations
M Source/WebCore/Sources.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/animation/KeyframeEffect.cpp
M Source/WebCore/css/CSSProperties.json
M Source/WebCore/css/scripts/process-css-properties.py
R
Source/WebCore/css/scripts/test/TestCSSPropertiesResults/RenderStyleInlinesGenerated.h
A
Source/WebCore/css/scripts/test/TestCSSPropertiesResults/RenderStyleProperties.h
A
Source/WebCore/css/scripts/test/TestCSSPropertiesResults/RenderStylePropertiesGetters.h
A
Source/WebCore/css/scripts/test/TestCSSPropertiesResults/RenderStylePropertiesGettersInlines.h
A
Source/WebCore/css/scripts/test/TestCSSPropertiesResults/RenderStylePropertiesSetters.h
A
Source/WebCore/css/scripts/test/TestCSSPropertiesResults/RenderStylePropertiesSettersInlines.h
R
Source/WebCore/css/scripts/test/TestCSSPropertiesResults/RenderStyleSettersGenerated.h
M Source/WebCore/rendering/RenderBoxModelObject.h
M Source/WebCore/rendering/RenderBoxModelObjectInlines.h
M Source/WebCore/rendering/style/BorderData.h
M Source/WebCore/rendering/style/BorderValue.h
M Source/WebCore/rendering/style/OutlineValue.h
M Source/WebCore/rendering/style/RenderStyle.cpp
M Source/WebCore/rendering/style/RenderStyle.h
A Source/WebCore/rendering/style/RenderStyleBase.cpp
A Source/WebCore/rendering/style/RenderStyleBase.h
A Source/WebCore/rendering/style/RenderStyleBaseInlines.h
A Source/WebCore/rendering/style/RenderStyleBaseSetters.h
M Source/WebCore/rendering/style/RenderStyleInlines.h
A Source/WebCore/rendering/style/RenderStylePropertiesGettersCustom.cpp
A Source/WebCore/rendering/style/RenderStylePropertiesGettersCustom.h
A Source/WebCore/rendering/style/RenderStylePropertiesSettersCustom.h
M Source/WebCore/rendering/style/RenderStyleSetters.h
M Source/WebCore/rendering/style/StyleRareNonInheritedData.cpp
M Source/WebCore/style/StyleInterpolationWrappers.h
M Source/WebCore/style/values/backgrounds/StyleBorderImage.h
M Source/WebCore/style/values/css2/StyleZIndex.h
M Source/WebCore/style/values/masking/StyleMaskBorder.h
M Source/WebCore/style/values/svg/StyleSVGPaint.cpp
M Tools/Scripts/webkitpy/style/checkers/jsonchecker.py
Log Message:
-----------
[RenderStyleGen] Generate getter/setter function declarations
https://bugs.webkit.org/show_bug.cgi?id=303356
Reviewed by Darin Adler.
To generate the declarations for RenderStyle's property getter/setters,
we have to split RenderStyle, ending up with three classes:
- RenderStyleBase: hand written, base class, contains member variables and
non-property getter/setters
- RenderStyleProperties: generated, derives from RenderStyleBase, contains
the property getter/setters
- RenderStyle: hand written, derives from RenderStyleProperties, contains
logic that depends on property getter/setters
I am not sure I have the exact right balance about what is in RenderStyleBase
vs RenderStyle, but that can be tweaked going forward.
* Source/WebCore/Headers.cmake:
* Source/WebCore/CMakeLists.txt:
* Source/WebCore/DerivedSources.make:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/animation/KeyframeEffect.cpp:
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/css/scripts/process-css-properties.py:
*
Source/WebCore/css/scripts/test/TestCSSPropertiesResults/RenderStyleInlinesGenerated.h:
Removed.
*
Source/WebCore/css/scripts/test/TestCSSPropertiesResults/RenderStyleProperties.h:
Added.
*
Source/WebCore/css/scripts/test/TestCSSPropertiesResults/RenderStylePropertiesGetters.h:
Added.
*
Source/WebCore/css/scripts/test/TestCSSPropertiesResults/RenderStylePropertiesSetters.h:
Copied from
Source/WebCore/css/scripts/test/TestCSSPropertiesResults/RenderStyleSettersGenerated.h.
*
Source/WebCore/css/scripts/test/TestCSSPropertiesResults/RenderStylePropertiesSettersInlines.h:
Renamed from
Source/WebCore/css/scripts/test/TestCSSPropertiesResults/RenderStyleSettersGenerated.h.
* Source/WebCore/rendering/RenderBoxModelObject.h:
* Source/WebCore/rendering/RenderBoxModelObjectInlines.h:
* Source/WebCore/rendering/style/BorderData.h:
* Source/WebCore/rendering/style/BorderValue.h:
* Source/WebCore/rendering/style/OutlineValue.h:
* Source/WebCore/rendering/style/RenderStyle.cpp:
* Source/WebCore/rendering/style/RenderStyle.h:
* Source/WebCore/rendering/style/RenderStyleBase.cpp: Added.
* Source/WebCore/rendering/style/RenderStyleBase.h: Added.
* Source/WebCore/rendering/style/RenderStyleBaseInlines.h: Added.
* Source/WebCore/rendering/style/RenderStyleBaseSetters.h: Added.
* Source/WebCore/rendering/style/RenderStyleInlines.h:
* Source/WebCore/rendering/style/RenderStylePropertiesGettersCustom.cpp: Added.
* Source/WebCore/rendering/style/RenderStylePropertiesGettersCustom.h: Added.
* Source/WebCore/rendering/style/RenderStylePropertiesSettersCustom.h: Added.
* Source/WebCore/rendering/style/RenderStyleSetters.h:
* Source/WebCore/rendering/style/StyleRareNonInheritedData.cpp:
* Source/WebCore/style/StyleInterpolationWrappers.h:
* Source/WebCore/style/values/backgrounds/StyleBorderImage.h:
* Source/WebCore/style/values/css2/StyleZIndex.h:
* Source/WebCore/style/values/masking/StyleMaskBorder.h:
* Source/WebCore/style/values/svg/StyleSVGPaint.cpp:
Canonical link: https://commits.webkit.org/304026@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
