Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 3d3fd8eb3c7a18570eb018349fc5025ec85b22f9
https://github.com/WebKit/WebKit/commit/3d3fd8eb3c7a18570eb018349fc5025ec85b22f9
Author: Simon Fraser <[email protected]>
Date: 2025-12-10 (Wed, 10 Dec 2025)
Changed paths:
M Source/WebCore/platform/mac/CursorMac.mm
Log Message:
-----------
REGRESSION (300377@main): Some CSS cursor values (move, all-scroll,
ew-resize, ns-resize) do not display the expected cursors
https://bugs.webkit.org/show_bug.cgi?id=303845
rdar://166160746
Reviewed by Tim Horton.
300377@main, which was Safer CPP cleanup, broke the assignment to the static
NSCursor*, which then caused `WKCoreCursor_coreCursorType()`
to fail.
Fix this confusing code by making an NSCursor subclass, and storing the
CoreCursorType inside it; this replaces the old swizzling.
There's no need to cache the WebCustomCursor at this level; `Cursor` objects
are already singletons.
Not testable because an API test can't warp the cursor without user annoyance.
* Source/WebCore/platform/mac/CursorMac.mm:
(-[WebCustomCursor initWithType:]):
(-[WebCustomCursor _coreCursorType]):
(WebCore::cursor):
(WebCore::WKCoreCursor_coreCursorType): Deleted.
(WebCore::createCoreCursorClassSingleton): Deleted.
(WebCore::coreCursorClassSingleton): Deleted.
Canonical link: https://commits.webkit.org/304232@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
