Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: cc456a2f26f697e46f5c237f50b1f00e2406e3d6
https://github.com/WebKit/WebKit/commit/cc456a2f26f697e46f5c237f50b1f00e2406e3d6
Author: Basuke Suzuki <[email protected]>
Date: 2025-12-10 (Wed, 10 Dec 2025)
Changed paths:
M Source/JavaScriptCore/inspector/JSGlobalObjectInspectorController.h
Log Message:
-----------
[Inspector] JSGlobalObjectInspectorController should use thread-safe
CheckedPtr to avoid destruction assertions.
https://bugs.webkit.org/show_bug.cgi?id=303870
rdar://166167124
Reviewed by Chris Dumez.
During JSGlobalObject destruction, the checkedInspectorController() method
creates
CheckedRef instances that may be called from different threads during garbage
collection. This causes SingleThreadIntegralWrapper assertions to fail when the
reference counting operations occur on a thread different from where the
inspector controller was originally created.
Fix by changing JSGlobalObjectInspectorController to inherit from
CanMakeThreadSafeCheckedPtr instead of CanMakeCheckedPtr, which uses atomic
operations for reference counting instead of thread-specific assertions.
Tests: Covered by testapi.
* Source/JavaScriptCore/inspector/JSGlobalObjectInspectorController.h:
Canonical link: https://commits.webkit.org/304274@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
