Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 2a9dd76543706856f70bed0eefd4b19327ec2782
https://github.com/WebKit/WebKit/commit/2a9dd76543706856f70bed0eefd4b19327ec2782
Author: Antoine Quint <[email protected]>
Date: 2025-12-12 (Fri, 12 Dec 2025)
Changed paths:
M Source/WebCore/platform/animation/AcceleratedEffect.cpp
Log Message:
-----------
[threaded-animations] many `css-view-transitions` WPT tests crash with
"Threaded Time-based Animations" enabled
https://bugs.webkit.org/show_bug.cgi?id=304077
Reviewed by Simon Fraser.
Fix the faulty logic when assembling keyframe values for `filter` and
`backdrop-filter`
in `AcceleratedEffect::validateFilters()`. Indeed, if only a single keyframe
was explicitly
provided, we would fail to reach the `else` statement for the case where
processing a keyframe
that was not explicitly affecting the provided property.
We now take a simpler approach by keeping a boolean flag that indicates whether
we've encountered
an explicit "to" keyframe and, if that flag is not set, add the implicit value.
Note that there is no test change in this patch since the flag is not yet
enabled on bots. This
was caught in preparation of that running animation tests locally using
`--experimental-feature ThreadedTimeBasedAnimationsEnabled=true`.
* Source/WebCore/platform/animation/AcceleratedEffect.cpp:
(WebCore::AcceleratedEffect::validateFilters):
Canonical link: https://commits.webkit.org/304377@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
