Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 443099fc5edfef2ed777e71bcfd754567f910d7a
https://github.com/WebKit/WebKit/commit/443099fc5edfef2ed777e71bcfd754567f910d7a
Author: Jer Noble <[email protected]>
Date: 2025-12-15 (Mon, 15 Dec 2025)
Changed paths:
A
LayoutTests/media/modern-media-controls/tracks-support/on-off-text-track-expected.txt
A
LayoutTests/media/modern-media-controls/tracks-support/on-off-text-track.html
M LayoutTests/platform/glib/TestExpectations
M Source/WebCore/CMakeLists.txt
M Source/WebCore/DerivedSources-input.xcfilelist
M Source/WebCore/DerivedSources-output.xcfilelist
M Source/WebCore/DerivedSources.make
A Source/WebCore/Modules/mediacontrols/MediaControlsContextMenuItem.idl
M Source/WebCore/Modules/mediacontrols/MediaControlsHost.cpp
M Source/WebCore/Modules/mediacontrols/MediaControlsHost.h
M Source/WebCore/Modules/mediacontrols/MediaControlsHost.idl
M Source/WebCore/Sources.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/html/HTMLMediaElement.cpp
M Source/WebCore/html/Origin.cpp
M Source/WebCore/html/Origin.h
M Source/WebCore/page/CaptionUserPreferences.cpp
M Source/WebCore/page/CaptionUserPreferences.h
M Source/WebCore/page/MediaControlsContextMenuItem.h
M Source/WebCore/testing/Internals.cpp
M Source/WebCore/testing/Internals.h
M Source/WebCore/testing/Internals.idl
Log Message:
-----------
On caption menu item doesn't enable text tracks
rdar://166158394
https://bugs.webkit.org/show_bug.cgi?id=304048
Reviewed by Eric Carlson.
Make "On" behave similarly to "Auto", which is to enable the highest
scoring text track available. Additionally, mark languages in the subtitle
menu as checked when they will be enabled by the "On" menu item.
Drive-by fix: Pass track and element parameters into CaptionUserPreferences
by reference rather than by pointer value.
Test: media/modern-media-controls/tracks-support/on-off-text-track.html
* LayoutTests/media/modern-media-controls/resources/media-controls-utils.js:
*
LayoutTests/media/modern-media-controls/tracks-support/on-off-text-track-expected.txt:
Added.
*
LayoutTests/media/modern-media-controls/tracks-support/on-off-text-track.html:
Added.
* Source/WebCore/Modules/mediacontrols/MediaControlsHost.cpp:
(WebCore::MediaControlsHost::captionMenuOnItem):
(WebCore::MediaControlsHost::showMediaControlsContextMenu):
* Source/WebCore/Modules/mediacontrols/MediaControlsHost.h:
* Source/WebCore/Modules/mediacontrols/MediaControlsHost.idl:
* Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::configureTextTrackGroup):
(WebCore::HTMLMediaElement::setSelectedTextTrack):
* Source/WebCore/page/CaptionUserPreferences.cpp:
(WebCore::CaptionUserPreferences::textTrackSelectionScore const):
(WebCore::CaptionUserPreferences::textTrackLanguageSelectionScore const):
* Source/WebCore/page/CaptionUserPreferences.h:
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::controlsHostForMediaElement):
* Source/WebCore/testing/Internals.h:
* Source/WebCore/testing/Internals.idl:
Canonical link: https://commits.webkit.org/304462@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
