Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ddb1fba3b7775671cedc966c2b9283e4fb64f54b
https://github.com/WebKit/WebKit/commit/ddb1fba3b7775671cedc966c2b9283e4fb64f54b
Author: Tyler Wilcock <[email protected]>
Date: 2025-12-15 (Mon, 15 Dec 2025)
Changed paths:
A LayoutTests/accessibility/text-stitching-inside-links-expected.txt
A LayoutTests/accessibility/text-stitching-inside-links.html
M LayoutTests/platform/glib/TestExpectations
M LayoutTests/platform/ios/TestExpectations
A
LayoutTests/platform/ios/accessibility/text-stitching-inside-links-expected.txt
M Source/WebCore/accessibility/AXStitchUtilities.cpp
M Source/WebCore/accessibility/AXStitchUtilities.h
M Source/WebCore/accessibility/AccessibilityNodeObject.cpp
Log Message:
-----------
AX: Accessibility text stitching doesn't happen within links, causing
unnecessary accessibility tree fragmentation
https://bugs.webkit.org/show_bug.cgi?id=304187
rdar://166544999
Reviewed by Joshua Hoffman.
Prior to this commit, we didn't stitch any text at all inside links, which is a
bad user experience. The intention was
to break up the stitch when entering a link, but the logic was simply
incorrect, so this commit fixes it.
Test: accessibility/text-stitching-inside-links.html
* LayoutTests/accessibility/text-stitching-inside-links-expected.txt: Added.
* LayoutTests/accessibility/text-stitching-inside-links.html: Added.
* LayoutTests/platform/glib/TestExpectations: Skip new test.
* LayoutTests/platform/ios/TestExpectations: Mark new test as passing.
* Source/WebCore/accessibility/AXStitchUtilities.cpp:
(WebCore::isStitchBreakingElement):
(WebCore::shouldStopStitchingAt):
* Source/WebCore/accessibility/AXStitchUtilities.h:
* Source/WebCore/accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::stitchGroups const):
Canonical link: https://commits.webkit.org/304491@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
