Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 41c6f81fa8535bc20d99a6e520683d1ae4961c8a
https://github.com/WebKit/WebKit/commit/41c6f81fa8535bc20d99a6e520683d1ae4961c8a
Author: Jessica Lee <[email protected]>
Date: 2025-12-16 (Tue, 16 Dec 2025)
Changed paths:
M Source/WebKitLegacy/mac/WebView/WebView.mm
Log Message:
-----------
WebView willStartRenderingUpdateDisplay crashes when _private->page is null
https://bugs.webkit.org/show_bug.cgi?id=302069
rdar://164022564
Reviewed by Chris Dumez and Ryosuke Niwa.
In the function WebView::_willStartRenderingUpdateDisplay (in WebkitLegacy),
the page can become null between when it is originally null-checked if
(_private->page) and when willStartRenderingUpdateDisplay starts executing.
This is due to an increased delay from WebThreadLock();
We should move WebThreadLock() before page->willStartRenderingUpdateDisplay
starts executing so that the page cannot be manipulated by the WebThread before
page->willStartRenderingUpdateDisplay runs.
* Source/WebKitLegacy/mac/WebView/WebView.mm:
(-[WebView _willStartRenderingUpdateDisplay]):
Originally-landed-as: cfc6df9eb93c. rdar://166335789
Canonical link: https://commits.webkit.org/304517@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
