Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 49c4b8c1c84e37bc1a11d4c53f6a144c07f76475
https://github.com/WebKit/WebKit/commit/49c4b8c1c84e37bc1a11d4c53f6a144c07f76475
Author: Cole Carley <[email protected]>
Date: 2025-12-16 (Tue, 16 Dec 2025)
Changed paths:
M Source/WebKit/UIProcess/ViewGestureController.cpp
M Source/WebKit/UIProcess/ViewGestureController.h
M Source/WebKit/UIProcess/gtk/ViewGestureControllerGtk.cpp
M Source/WebKit/UIProcess/ios/ViewGestureControllerIOS.mm
M Source/WebKit/UIProcess/mac/ViewGestureControllerMac.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm
Log Message:
-----------
REGRESSION( iOS 26): 2X TestWebKitAPI.ProcessSwap gesture controller API
Tests are constant failures
https://bugs.webkit.org/show_bug.cgi?id=301536
rdar://163517689
Reviewed by Aditya Keerthi and Rupin Mittal.
The gesture recognizers were not being properly removed on process swaps. I
added a
new method platformDisconnectFromProcess to remove the stale gesture
recognizers.
Test: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm
* Source/WebKit/UIProcess/ViewGestureController.cpp:
(WebKit::ViewGestureController::disconnectFromProcess):
* Source/WebKit/UIProcess/ViewGestureController.h:
* Source/WebKit/UIProcess/gtk/ViewGestureControllerGtk.cpp:
(WebKit::ViewGestureController::platformDisconnectFromProcess):
* Source/WebKit/UIProcess/ios/ViewGestureControllerIOS.mm:
(-[WKSwipeTransitionController invalidate]):
(WebKit::ViewGestureController::platformDisconnectFromProcess):
* Source/WebKit/UIProcess/mac/ViewGestureControllerMac.mm:
(WebKit::ViewGestureController::platformDisconnectFromProcess):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
((ProcessSwap, SwapWithGestureController)):
((ProcessSwap, CrashWithGestureController)(ProcessSwap,
CrashWithGestureController)):
((ProcessSwap, DISABLED_SwapWithGestureController)(ProcessSwap,
SwapWithGestureController)): Deleted.
((ProcessSwap, DISABLED_CrashWithGestureController)(ProcessSwap,
CrashWithGestureController)): Deleted.
Canonical link: https://commits.webkit.org/304570@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
