Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5bf123876b61a6b0172fd0001980f52f929e3da0
      
https://github.com/WebKit/WebKit/commit/5bf123876b61a6b0172fd0001980f52f929e3da0
  Author: Joshua Hoffman <[email protected]>
  Date:   2025-12-17 (Wed, 17 Dec 2025)

  Changed paths:
    A LayoutTests/accessibility/mac/live-regions/live-region-button-expected.txt
    A LayoutTests/accessibility/mac/live-regions/live-region-button.html
    M Source/WebCore/accessibility/AXCoreObject.cpp
    M Source/WebCore/accessibility/AXCoreObject.h
    M Source/WebCore/accessibility/AXLiveRegionManager.cpp

  Log Message:
  -----------
  AX: [LiveRegionManagement] Buttons aren't included in live region 
announcements
https://bugs.webkit.org/show_bug.cgi?id=304289
rdar://166649406

Reviewed by Tyler Wilcock.

Buttons return their inner text via `title()`, which was not in the 
consideration criteria
for live region objects. Now, we check if leaf elements have non-empty title 
before excluding
them.

Test: accessibility/mac/live-regions/live-region-button.html

* LayoutTests/accessibility/mac/live-regions/live-region-button-expected.txt: 
Added.
* LayoutTests/accessibility/mac/live-regions/live-region-button.html: Added.
* Source/WebCore/accessibility/AXCoreObject.cpp:
(WebCore::AXCoreObject::descriptionAttributeValue const):
(WebCore::AXCoreObject::title const):
* Source/WebCore/accessibility/AXCoreObject.h:
* Source/WebCore/accessibility/AXLiveRegionManager.cpp:
(WebCore::AXLiveRegionManager::shouldIncludeInSnapshot const):

Canonical link: https://commits.webkit.org/304607@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications

Reply via email to