Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 10ae7dbc90309fc2e09c0cd83fdc7590481a322e
https://github.com/WebKit/WebKit/commit/10ae7dbc90309fc2e09c0cd83fdc7590481a322e
Author: Brandon Stewart <[email protected]>
Date: 2025-12-17 (Wed, 17 Dec 2025)
Changed paths:
M LayoutTests/inspector/dom/showFlexOverlay-expected.txt
M LayoutTests/inspector/dom/showFlexOverlay.html
M LayoutTests/inspector/dom/showGridOverlay-expected.txt
M LayoutTests/inspector/dom/showGridOverlay.html
M Source/JavaScriptCore/inspector/protocol/DOM.json
M Source/WebCore/en.lproj/Localizable.strings
M Source/WebCore/inspector/InspectorOverlay.cpp
M Source/WebCore/inspector/InspectorOverlay.h
M Source/WebCore/inspector/agents/InspectorDOMAgent.cpp
M Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
M Source/WebInspectorUI/UserInterface/Base/Setting.js
M Source/WebInspectorUI/UserInterface/Controllers/DOMManager.js
M Source/WebInspectorUI/UserInterface/Models/DOMNode.js
M Source/WebInspectorUI/UserInterface/Views/LayoutDetailsSidebarPanel.js
Log Message:
-----------
Web Inspector: Add Order Number to display: grid and grid-lanes
https://bugs.webkit.org/show_bug.cgi?id=304287
rdar://problem/166648769
Reviewed by BJ Burg and Devin Rousso.
Add an "Order Numbers" option to CSS Grid overlays in Web Inspector, matching
the existing functionality for Flexbox overlays.
The implementation supports both regular CSS Grid layouts and CSS Masonry
layouts.
For regular grids, item bounds are computed from grid area lines. For masonry
layouts, the item's frame rect is used directly since grid areas may not have
definite positions in the masonry axis.
* LayoutTests/inspector/dom/showFlexOverlay-expected.txt:
* LayoutTests/inspector/dom/showFlexOverlay.html:
* LayoutTests/inspector/dom/showGridOverlay-expected.txt:
* LayoutTests/inspector/dom/showGridOverlay.html:
* Source/JavaScriptCore/inspector/protocol/DOM.json:
* Source/WebCore/en.lproj/Localizable.strings:
* Source/WebCore/inspector/InspectorOverlay.cpp:
(WebCore::InspectorOverlay::clearGridOverlayForNode):
(WebCore::InspectorOverlay::clearFlexOverlayForNode):
(WebCore::InspectorOverlay::buildGridOverlay):
(WebCore::InspectorOverlay::buildFlexOverlay):
* Source/WebCore/inspector/InspectorOverlay.h:
* Source/WebCore/inspector/agents/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::gridOverlayConfigFromInspectorObject):
* Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:
* Source/WebInspectorUI/UserInterface/Base/Setting.js:
* Source/WebInspectorUI/UserInterface/Controllers/DOMManager.js:
(WI.DOMManager.buildHighlightConfigs):
* Source/WebInspectorUI/UserInterface/Models/DOMNode.js:
(WI.DOMNode.prototype.set layoutFlags):
(WI.DOMNode.prototype.showLayoutOverlay):
(WI.DOMNode.prototype.hideLayoutOverlay):
* Source/WebInspectorUI/UserInterface/Views/LayoutDetailsSidebarPanel.js:
(WI.LayoutDetailsSidebarPanel.prototype.initialLayout):
Canonical link: https://commits.webkit.org/304645@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
