Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: dc880037ea922078dc67a058b9302b71c92f9378
https://github.com/WebKit/WebKit/commit/dc880037ea922078dc67a058b9302b71c92f9378
Author: Ahmad Saleem <[email protected]>
Date: 2026-01-05 (Mon, 05 Jan 2026)
Changed paths:
M Source/WebCore/rendering/svg/RenderSVGShape.cpp
M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGShape.cpp
Log Message:
-----------
Address feedback post 305077@main (early return, optimization and cleaner
code)
https://bugs.webkit.org/show_bug.cgi?id=304947
rdar://167563795
Reviewed by Said Abou-Hallawa.
This patch addresses Said's feedback post 305077@main landing, it adds
following:
> Use `this->` pattern to call function.
> Early return to avoid doing work when path is not `non-scaling`.`
> Adds optimization where `xScale == yScale`.
> Use `return strokeWidth / scaleFactor` consistent with codebase.
* Source/WebCore/rendering/svg/RenderSVGShape.cpp:
(WebCore::RenderSVGShape::strokeWidthForMarkerUnits const):
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGShape.cpp:
(WebCore::LegacyRenderSVGShape::strokeWidthForMarkerUnits const):
Canonical link: https://commits.webkit.org/305125@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
