Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 7dcb5b690a092f621e586e0f28f066290d386f05
https://github.com/WebKit/WebKit/commit/7dcb5b690a092f621e586e0f28f066290d386f05
Author: Qianlang Chen <[email protected]>
Date: 2026-01-05 (Mon, 05 Jan 2026)
Changed paths:
M Source/JavaScriptCore/inspector/protocol/Animation.json
M Source/JavaScriptCore/inspector/protocol/Audit.json
M Source/JavaScriptCore/inspector/protocol/CPUProfiler.json
M Source/JavaScriptCore/inspector/protocol/CSS.json
M Source/JavaScriptCore/inspector/protocol/Canvas.json
M Source/JavaScriptCore/inspector/protocol/Console.json
M Source/JavaScriptCore/inspector/protocol/DOM.json
M Source/JavaScriptCore/inspector/protocol/DOMDebugger.json
M Source/JavaScriptCore/inspector/protocol/DOMStorage.json
M Source/JavaScriptCore/inspector/protocol/Debugger.json
M Source/JavaScriptCore/inspector/protocol/Heap.json
M Source/JavaScriptCore/inspector/protocol/IndexedDB.json
M Source/JavaScriptCore/inspector/protocol/Inspector.json
M Source/JavaScriptCore/inspector/protocol/LayerTree.json
M Source/JavaScriptCore/inspector/protocol/Memory.json
M Source/JavaScriptCore/inspector/protocol/Network.json
M Source/JavaScriptCore/inspector/protocol/Page.json
M Source/JavaScriptCore/inspector/protocol/Recording.json
M Source/JavaScriptCore/inspector/protocol/Runtime.json
M Source/JavaScriptCore/inspector/protocol/ScriptProfiler.json
M Source/JavaScriptCore/inspector/protocol/Security.json
M Source/JavaScriptCore/inspector/protocol/Timeline.json
M Source/JavaScriptCore/inspector/protocol/Worker.json
M Source/JavaScriptCore/inspector/remote/RemoteControllableTarget.h
M Source/JavaScriptCore/inspector/remote/RemoteInspectorConstants.h
M Source/JavaScriptCore/inspector/remote/cocoa/RemoteInspectorCocoa.mm
M Source/JavaScriptCore/inspector/remote/socket/RemoteInspectorSocket.cpp
M Source/JavaScriptCore/inspector/scripts/codegen/models.py
M
Source/JavaScriptCore/inspector/scripts/tests/command-targetType-matching-domain-debuggableType.json
M
Source/JavaScriptCore/inspector/scripts/tests/domain-targetType-matching-domain-debuggableType.json
M
Source/JavaScriptCore/inspector/scripts/tests/event-targetType-matching-domain-debuggableType.json
M
Source/JavaScriptCore/inspector/scripts/tests/expected/command-targetType-matching-domain-debuggableType.json-result
M
Source/JavaScriptCore/inspector/scripts/tests/expected/domain-targetType-matching-domain-debuggableType.json-result
M
Source/JavaScriptCore/inspector/scripts/tests/expected/event-targetType-matching-domain-debuggableType.json-result
M
Source/JavaScriptCore/inspector/scripts/tests/expected/fail-on-domain-debuggableTypes-value.json-error
M Source/WebCore/PlatformMac.cmake
M Source/WebCore/Sources.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/inspector/PageInspectorController.cpp
M Source/WebCore/loader/FrameLoader.cpp
M Source/WebCore/page/Page.cpp
M Source/WebCore/page/Page.h
R Source/WebCore/page/PageDebuggable.cpp
R Source/WebCore/page/PageDebuggable.h
M Source/WebCore/testing/Internals.cpp
M Source/WebCore/workers/service/context/ServiceWorkerThreadProxy.cpp
M Source/WebKit/Shared/DebuggableInfoData.cpp
M Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.cpp
Log Message:
-----------
Web Inspector: Remove the deprecated PageDebuggable
rdar://164588069
https://bugs.webkit.org/show_bug.cgi?id=302429
Reviewed by BJ Burg.
Remove the deprecated page debuggable type since WebKitLegacy now
also creates a web-page debuggable as of 304467@main.
No new tests; observable inspection behavior should stay the same.
Inspector protocol generator and its tests are updated to stop using or
expecting the page debuggable.
* Source/JavaScriptCore/inspector/protocol/Animation.json:
* Source/JavaScriptCore/inspector/protocol/Audit.json:
* Source/JavaScriptCore/inspector/protocol/CPUProfiler.json:
* Source/JavaScriptCore/inspector/protocol/CSS.json:
* Source/JavaScriptCore/inspector/protocol/Canvas.json:
* Source/JavaScriptCore/inspector/protocol/Console.json:
* Source/JavaScriptCore/inspector/protocol/DOM.json:
* Source/JavaScriptCore/inspector/protocol/DOMDebugger.json:
* Source/JavaScriptCore/inspector/protocol/DOMStorage.json:
* Source/JavaScriptCore/inspector/protocol/Debugger.json:
* Source/JavaScriptCore/inspector/protocol/Heap.json:
* Source/JavaScriptCore/inspector/protocol/IndexedDB.json:
* Source/JavaScriptCore/inspector/protocol/Inspector.json:
* Source/JavaScriptCore/inspector/protocol/LayerTree.json:
* Source/JavaScriptCore/inspector/protocol/Memory.json:
* Source/JavaScriptCore/inspector/protocol/Network.json:
* Source/JavaScriptCore/inspector/protocol/Page.json:
* Source/JavaScriptCore/inspector/protocol/Recording.json:
* Source/JavaScriptCore/inspector/protocol/Runtime.json:
* Source/JavaScriptCore/inspector/protocol/ScriptProfiler.json:
* Source/JavaScriptCore/inspector/protocol/Security.json:
* Source/JavaScriptCore/inspector/protocol/Timeline.json:
* Source/JavaScriptCore/inspector/protocol/Worker.json:
* Source/JavaScriptCore/inspector/remote/RemoteControllableTarget.h:
* Source/JavaScriptCore/inspector/remote/RemoteInspectorConstants.h:
* Source/JavaScriptCore/inspector/remote/cocoa/RemoteInspectorCocoa.mm:
(Inspector::RemoteInspector::listingForInspectionTarget const):
* Source/JavaScriptCore/inspector/remote/socket/RemoteInspectorSocket.cpp:
(Inspector::RemoteInspector::listingForInspectionTarget const):
* Source/JavaScriptCore/inspector/scripts/codegen/models.py:
(validate_target_types):
*
Source/JavaScriptCore/inspector/scripts/tests/command-targetType-matching-domain-debuggableType.json:
*
Source/JavaScriptCore/inspector/scripts/tests/domain-targetType-matching-domain-debuggableType.json:
*
Source/JavaScriptCore/inspector/scripts/tests/event-targetType-matching-domain-debuggableType.json:
*
Source/JavaScriptCore/inspector/scripts/tests/expected/command-targetType-matching-domain-debuggableType.json-result:
*
Source/JavaScriptCore/inspector/scripts/tests/expected/domain-targetType-matching-domain-debuggableType.json-result:
*
Source/JavaScriptCore/inspector/scripts/tests/expected/event-targetType-matching-domain-debuggableType.json-result:
*
Source/JavaScriptCore/inspector/scripts/tests/expected/fail-on-domain-debuggableTypes-value.json-error:
* Source/WebCore/PlatformMac.cmake:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/inspector/PageInspectorController.cpp:
(WebCore::PageInspectorController::connectFrontend):
(WebCore::PageInspectorController::disconnectFrontend):
(WebCore::PageInspectorController::disconnectAllFrontends):
(WebCore::PageInspectorController::frontendInitialized):
* Source/WebCore/loader/FrameLoader.cpp:
(WebCore::FrameLoader::didChangeTitle):
(WebCore::FrameLoader::dispatchDidCommitLoad):
* Source/WebCore/page/Page.cpp:
(WebCore::Page::Page):
(WebCore::Page::~Page):
(WebCore::Page::inspectable const): Deleted.
(WebCore::Page::setInspectable): Deleted.
(WebCore::Page::remoteInspectionNameOverride const): Deleted.
(WebCore::Page::setRemoteInspectionNameOverride): Deleted.
(WebCore::Page::remoteInspectorInformationDidChange): Deleted.
* Source/WebCore/page/Page.h:
(WebCore::Page::inspectorDebuggable): Deleted.
(WebCore::Page::inspectorDebuggable const): Deleted.
* Source/WebCore/page/PageDebuggable.cpp: Removed.
* Source/WebCore/page/PageDebuggable.h: Removed.
* Source/WebCore/testing/Internals.cpp:
* Source/WebCore/workers/service/context/ServiceWorkerThreadProxy.cpp:
(WebCore::ServiceWorkerThreadProxy::setInspectable):
* Source/WebKit/Shared/DebuggableInfoData.cpp:
(WebKit::DebuggableInfoData::empty):
* Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.cpp:
(WebKit::WebSWContextManagerConnection::installServiceWorker):
Canonical link: https://commits.webkit.org/305128@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
