Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 5f949b14dae9dccbf2d519e6ce4e653a1debb9d5
https://github.com/WebKit/WebKit/commit/5f949b14dae9dccbf2d519e6ce4e653a1debb9d5
Author: Sam Weinig <[email protected]>
Date: 2026-01-06 (Tue, 06 Jan 2026)
Changed paths:
M
LayoutTests/accessibility/ios-simulator/taking-focus-should-refocus-page-expected.txt
M
LayoutTests/accessibility/ios-simulator/taking-focus-should-refocus-page.html
M LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt
M
LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt
M
LayoutTests/fast/css/getComputedStyle/getComputedStyle-outline-shorthand-expected.txt
M LayoutTests/fast/replaced/resources/focus-test.js
M
LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/outline-width.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-ui/outline-009-expected.html
R
LayoutTests/imported/w3c/web-platform-tests/css/css-ui/outline-009-expected.xht
M LayoutTests/imported/w3c/web-platform-tests/css/css-ui/outline-009.html
M
LayoutTests/imported/w3c/web-platform-tests/css/css-ui/parsing/canonical-order-outline-sub-properties-001-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-ui/parsing/outline-offset-computed-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-ui/parsing/outline-offset-computed.html
M
LayoutTests/imported/w3c/web-platform-tests/css/css-ui/parsing/outline-width-computed-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-ui/parsing/outline-width-computed.html
M LayoutTests/media/video-mouse-focus-expected.txt
M LayoutTests/media/video-mouse-focus.html
M LayoutTests/svg/css/getComputedStyle-basic-expected.txt
M Source/WebCore/accessibility/AccessibilityRenderObject.cpp
M Source/WebCore/css/CSSProperties.json
M
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp
M Source/WebCore/rendering/BorderEdge.cpp
M Source/WebCore/rendering/OutlinePainter.cpp
M Source/WebCore/rendering/RenderBox.cpp
M Source/WebCore/rendering/RenderElement.cpp
M Source/WebCore/rendering/RenderImage.cpp
M Source/WebCore/rendering/RenderInline.cpp
M Source/WebCore/rendering/RenderObject.cpp
M Source/WebCore/rendering/RenderReplaced.cpp
M Source/WebCore/rendering/RenderTableCell.cpp
M Source/WebCore/rendering/cocoa/RenderThemeCocoa.mm
M Source/WebCore/rendering/style/RenderStyle+GettersInlines.h
M Source/WebCore/rendering/style/RenderStyle.cpp
M Source/WebCore/rendering/style/RenderStyle.h
M Source/WebCore/rendering/style/RenderStyleBase+GettersInlines.h
M Source/WebCore/rendering/style/RenderStyleBase.h
M Source/WebCore/rendering/svg/SVGBoundingBoxComputation.cpp
M Source/WebCore/rendering/svg/SVGRenderSupport.cpp
M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGContainer.cpp
M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGImage.cpp
M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGModelObject.cpp
M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGShape.cpp
M Source/WebCore/style/StyleDifference.cpp
M
Source/WebCore/style/computed/StyleComputedStyleProperties+GettersCustom.cpp
Log Message:
-----------
Update outline-width and outline-offset to match updated computed style
resolution rules
https://bugs.webkit.org/show_bug.cgi?id=304909
Reviewed by Darin Adler.
The rules for the `outline-width` property's computed value resolution were
updated with
https://github.com/w3c/csswg-drafts/issues/11494 to disentangle `outline-width`
and
`outline-style` for computed style, making `outline-style` only effect the used
value.
We also erroneously entangled `outline-offset`, so we fix that here too.
To make it harder for rendering code to use the computed value (which does not
apply
`outline-style`), `RenderStyle::outlineWidth()` and
`RenderStyle::outlineOffset()`
no longer exist at all (skipped via `skip-render-style-getter` codegen entry)
and
instead `RenderStyle::usedOutlineWidth()` and `RenderStyle::usedOutlineOffset()`
exist in their place. If someone really wants the computed value, they can use
`RenderStyle::computedStyle().outlineWidth()/outlineStyle()`, which is what the
style extractor does.
Also renamed `RenderStyle::outlineSize()` to `RenderStyle::usedOutlineSize()`
for
consistency with the two new functions.
* LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt:
*
LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
*
LayoutTests/fast/css/getComputedStyle/getComputedStyle-outline-shorthand-expected.txt:
* LayoutTests/fast/css/getComputedStyle/getComputedStyle-outline-shorthand.html:
* LayoutTests/fast/replaced/resources/focus-test.js:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/outline-width.html:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-ui/outline-009-expected.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-ui/outline-009-expected.xht:
Removed.
* LayoutTests/imported/w3c/web-platform-tests/css/css-ui/outline-009.html:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-ui/parsing/canonical-order-outline-sub-properties-001-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-ui/parsing/canonical-order-outline-sub-properties-001.html:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-ui/parsing/outline-offset-computed-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-ui/parsing/outline-offset-computed.html:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-ui/parsing/outline-width-computed-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-ui/parsing/outline-width-computed.html:
* LayoutTests/media/video-mouse-focus-expected.txt:
* LayoutTests/media/video-mouse-focus.html:
* LayoutTests/svg/css/getComputedStyle-basic-expected.txt:
* Source/WebCore/accessibility/AccessibilityRenderObject.cpp:
* Source/WebCore/css/CSSProperties.json:
*
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:
* Source/WebCore/rendering/BorderEdge.cpp:
* Source/WebCore/rendering/OutlinePainter.cpp:
* Source/WebCore/rendering/RenderBox.cpp:
* Source/WebCore/rendering/RenderElement.cpp:
* Source/WebCore/rendering/RenderImage.cpp:
* Source/WebCore/rendering/RenderInline.cpp:
* Source/WebCore/rendering/RenderObject.cpp:
* Source/WebCore/rendering/RenderReplaced.cpp:
* Source/WebCore/rendering/RenderTableCell.cpp:
* Source/WebCore/rendering/cocoa/RenderThemeCocoa.mm:
* Source/WebCore/rendering/style/RenderStyle+GettersInlines.h:
* Source/WebCore/rendering/style/RenderStyle.cpp:
* Source/WebCore/rendering/style/RenderStyle.h:
* Source/WebCore/rendering/svg/SVGBoundingBoxComputation.cpp:
* Source/WebCore/rendering/svg/SVGRenderSupport.cpp:
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGContainer.cpp:
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGImage.cpp:
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGModelObject.cpp:
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGShape.cpp:
* Source/WebCore/style/StyleDifference.cpp:
* Source/WebCore/style/computed/StyleComputedStyleProperties+GettersCustom.cpp:
Canonical link: https://commits.webkit.org/305153@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
