Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: a1f5e0b127616791f89c55dfce1e2e4f2d9016a5
https://github.com/WebKit/WebKit/commit/a1f5e0b127616791f89c55dfce1e2e4f2d9016a5
Author: Andres Gonzalez <[email protected]>
Date: 2026-01-06 (Tue, 06 Jan 2026)
Changed paths:
M Source/WebCore/accessibility/AXCoreObject.h
M Source/WebCore/accessibility/AccessibilityObject.h
M Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm
M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h
Log Message:
-----------
AX: Refactor six ancestor-finding methods in AXCoreObject from pure virtual,
template-based implementations to non-virtual inline member functions.
https://bugs.webkit.org/show_bug.cgi?id=304967
<rdar://problem/167591275>
Reviewed by Tyler Wilcock.
No change in functionality.
This patch refactors six ancestor-finding methods in AXCoreObject from pure
virtual, template-based implementations to non-virtual inline member functions.
The refactoring improves const-correctness, simplifies the inheritance
hierarchy, and eliminates virtual dispatch overhead.
* Source/WebCore/accessibility/AXCoreObject.h:
(WebCore::AXCoreObject::editableAncestor const):
(WebCore::AXCoreObject::highestEditableAncestor const):
(WebCore::AXCoreObject::focusableAncestor const):
(WebCore::AXCoreObject::clickableSelfOrAncestor const):
(WebCore::AXCoreObject::liveRegionAncestor const):
(WebCore::AXCoreObject::exposedTableAncestor const):
(WebCore::Accessibility::focusableAncestor): Deleted.
(WebCore::Accessibility::editableAncestor): Deleted.
(WebCore::Accessibility::highestEditableAncestor): Deleted.
(WebCore::Accessibility::liveRegionAncestor): Deleted.
(WebCore::Accessibility::exposedTableAncestor): Deleted.
* Source/WebCore/accessibility/AccessibilityObject.h:
* Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilityHeaderElements]):
(-[WebAccessibilityObjectWrapper accessibilityElementForRow:andColumn:]):
(-[WebAccessibilityObjectWrapper accessibilityRowCount]):
(-[WebAccessibilityObjectWrapper accessibilityColumnCount]):
(-[WebAccessibilityObjectWrapper accessibilityARIARowCount]):
(-[WebAccessibilityObjectWrapper accessibilityARIAColumnCount]):
(-[WebAccessibilityObjectWrapper tableParent]): Deleted.
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:
In both derived classes, removed simple forwarding functions to the template
implementations. With the base class now providing concrete implementations,
these overrides are no longer needed.
Canonical link: https://commits.webkit.org/305170@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
