Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 99d7f658ab048449ea97edacd7a539fac1bc1996
https://github.com/WebKit/WebKit/commit/99d7f658ab048449ea97edacd7a539fac1bc1996
Author: Pascoe <[email protected]>
Date: 2026-01-06 (Tue, 06 Jan 2026)
Changed paths:
M Source/WebKit/NetworkProcess/NetworkProcess.cpp
M Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.h
M
Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.serialization.in
M Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp
M Source/WebKit/UIProcess/Network/NetworkProcessProxy.h
M Source/WebKit/UIProcess/WebPageProxy.cpp
Log Message:
-----------
Potential crash under WebPageProxy::executeEditCommand()
rdar://145887512
https://bugs.webkit.org/show_bug.cgi?id=301321
Reviewed by Charlie Wolfe.
Hardening fix to avoid calling protectedConnection() when the NetworkProcess
doesn't have an established connection yet. Also add hasRunningProcess() check
in the callback version's completion handler.
Additionally, track pending file paths that need to be allowed in
NetworkProcessProxy (similar to allowedFirstPartiesForCookies) and send them
via NetworkProcessCreationParameters when the NetworkProcess launches. This
ensures file access is properly granted even if NetworkProcess crashes and
restarts.
This fix is somewhat speculative as I couldn't reproduce the crash in testing.
* Source/WebKit/NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::initializeNetworkProcess):
* Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.h:
*
Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.serialization.in:
* Source/WebKit/UIProcess/Cocoa/WebPasteboardProxyCocoa.mm:
(WebKit::WebPasteboardProxy::grantAccessToCurrentData):
* Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::sendCreationParametersToNewProcess):
(WebKit::NetworkProcessProxy::networkProcessDidTerminate):
(WebKit::NetworkProcessProxy::addPendingAllowedFilePaths):
* Source/WebKit/UIProcess/Network/NetworkProcessProxy.h:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::executeEditCommand):
Canonical link: https://commits.webkit.org/305173@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
