Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 770c1d15fd2ccbf938fec511895c5afdd0688ff7
https://github.com/WebKit/WebKit/commit/770c1d15fd2ccbf938fec511895c5afdd0688ff7
Author: Simon Fraser <[email protected]>
Date: 2026-01-06 (Tue, 06 Jan 2026)
Changed paths:
M LayoutTests/css3/filters/effect-reference-expected.txt
M LayoutTests/css3/filters/effect-reference-hw-expected.txt
M LayoutTests/platform/glib/css3/filters/effect-reference-expected.txt
M LayoutTests/platform/glib/css3/filters/effect-reference-hw-expected.txt
M
LayoutTests/platform/glib/svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt
M LayoutTests/platform/ios/css3/filters/effect-reference-expected.txt
M LayoutTests/platform/ios/css3/filters/effect-reference-hw-expected.txt
M
LayoutTests/platform/ios/svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt
M LayoutTests/platform/win/css3/filters/effect-reference-expected.txt
M LayoutTests/platform/win/css3/filters/effect-reference-hw-expected.txt
M
LayoutTests/platform/wpe-legacy-api/svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt
M LayoutTests/svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt
M LayoutTests/svg/filters/feLighting-crash-expected.txt
M Source/WebCore/SourcesCocoa.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
A Source/WebCore/platform/graphics/coreimage/FELightingCoreImageApplier.h
A Source/WebCore/platform/graphics/coreimage/FELightingCoreImageApplier.mm
M Source/WebCore/platform/graphics/filters/FELighting.cpp
M Source/WebCore/platform/graphics/filters/FELighting.h
M Source/WebCore/platform/graphics/filters/FESpecularLighting.cpp
Log Message:
-----------
[CI Filters] FELighting in Core Image
https://bugs.webkit.org/show_bug.cgi?id=304876
rdar://167458230
Reviewed by Mike Wyrzykowski.
Core Image implementation of FEDiffuseLighting and FESpecularLighting. These
share a lot of code, so use the same kernel. There are a few FIXMEs that need
addressing, but this rendering almost exactly matches the software applier.
Fix a typo in the external representation ("specualConstant" ->
"specularConstant")
and update results accordingly.
* LayoutTests/css3/filters/effect-reference-expected.txt:
* LayoutTests/css3/filters/effect-reference-hw-expected.txt:
* LayoutTests/platform/glib/css3/filters/effect-reference-expected.txt:
* LayoutTests/platform/glib/css3/filters/effect-reference-hw-expected.txt:
* LayoutTests/platform/glib/svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt:
* LayoutTests/platform/ios/css3/filters/effect-reference-expected.txt:
* LayoutTests/platform/ios/css3/filters/effect-reference-hw-expected.txt:
* LayoutTests/platform/ios/svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt:
* LayoutTests/platform/win/css3/filters/effect-reference-expected.txt:
* LayoutTests/platform/win/css3/filters/effect-reference-hw-expected.txt:
*
LayoutTests/platform/wpe-legacy-api/svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt:
* LayoutTests/svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt:
* LayoutTests/svg/filters/feLighting-crash-expected.txt:
* Source/WebCore/SourcesCocoa.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/platform/graphics/coreimage/FELightingCoreImageApplier.h:
Added.
* Source/WebCore/platform/graphics/coreimage/FELightingCoreImageApplier.mm:
Added.
(WebCore::specularLightingKernel):
* Source/WebCore/platform/graphics/coreimage/FETurbulenceCoreImageApplier.mm:
* Source/WebCore/platform/graphics/filters/FELighting.cpp:
(WebCore::FELighting::supportedFilterRenderingModes const):
(WebCore::FELighting::createAcceleratedApplier const):
* Source/WebCore/platform/graphics/filters/FELighting.h:
* Source/WebCore/platform/graphics/filters/FESpecularLighting.cpp:
(WebCore::FESpecularLighting::externalRepresentation const): Fix a typo.
Canonical link: https://commits.webkit.org/305205@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
