Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 8c44752f8ddb2a2856f4d6dfd6474b3ffea5e657
https://github.com/WebKit/WebKit/commit/8c44752f8ddb2a2856f4d6dfd6474b3ffea5e657
Author: Sam Weinig <[email protected]>
Date: 2026-01-07 (Wed, 07 Jan 2026)
Changed paths:
M LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt
M
LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt
M
LayoutTests/fast/css/getComputedStyle/getComputedStyle-column-rule-expected.txt
M LayoutTests/fast/css/getComputedStyle/getComputedStyle-column-rule.html
M
LayoutTests/imported/w3c/web-platform-tests/css/css-multicol/animation/column-rule-width-interpolation-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-multicol/parsing/column-rule-computed-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-multicol/parsing/column-rule-width-computed-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/column-rule-width-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/column-rule-width.html
A
LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/css-multicol/animation/column-rule-width-interpolation-expected.txt
M LayoutTests/svg/css/getComputedStyle-basic-expected.txt
M Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
M Source/WebCore/css/CSSProperties.json
M Source/WebCore/rendering/BorderEdge.cpp
M Source/WebCore/rendering/BorderEdge.h
M Source/WebCore/rendering/RenderMultiColumnSet.cpp
M Source/WebCore/rendering/style/BorderValue.cpp
M Source/WebCore/rendering/style/BorderValue.h
M Source/WebCore/rendering/style/CollapsedBorderValue.h
M Source/WebCore/rendering/style/OutlineValue.cpp
M Source/WebCore/rendering/style/OutlineValue.h
M Source/WebCore/rendering/style/RenderStyle+GettersInlines.h
M Source/WebCore/rendering/style/RenderStyle.cpp
M Source/WebCore/rendering/style/RenderStyle.h
M Source/WebCore/rendering/style/RenderStyleBase+GettersInlines.h
M Source/WebCore/rendering/style/RenderStyleBase.h
M Source/WebCore/rendering/style/RenderStyleConstants.h
M
Source/WebCore/style/computed/StyleComputedStyleProperties+GettersCustomInlines.h
M Source/WebCore/style/computed/data/StyleMultiColumnData.cpp
M Source/WebCore/style/computed/data/StyleMultiColumnData.h
M Source/WebCore/style/values/color/StyleColor.cpp
M Source/WebCore/style/values/color/StyleColor.h
Log Message:
-----------
Update column-rule-width to match updated computed style resolution rules
https://bugs.webkit.org/show_bug.cgi?id=304940
Reviewed by Darin Adler.
The rules for the `column-rule-width` property's computed value resolution were
updated with
https://github.com/w3c/csswg-drafts/issues/11494 to disentangle
`column-rule-width` and
`column-rule-style` for computed style, making `column-rule-style` only effect
the used value.
As was done with `outline-width`, which had the same change made,
`RenderStyle::columnRuleWidth()`
has been removed and replaced by `RenderStyle::usedColumnRuleWidth()`. To get
the computed style
one can use RenderStyle::computedStyle().columnRuleWidth()` as the extractor
does.
A few related cleanups were also performed.
- Replaced the `isTransparent` member functions on `BorderValue` and
`OutlineValue` by adding
a `Style::Color::isKnownTransparent()` member function that does the same
thing. With that
available, the `RenderStyle::{...}IsTransparent()` member functions were no
longer useful,
as the corresponding `{...}Color.isKnownTransparent()` now works just as well.
- Added an inline helper function `isVisibleBorderStyle()` to replace explicit
range checks
against BorderStyle.
- Moved some conditions in RenderMultiColumnSet::paintColumnRules() to only run
after an
early return to avoid unnecessary work.
While it looks like
`css/css-multicol/animation/column-rule-width-interpolation.html` is a
regression
the test was previously not really testing anything, as it only looks at
getComputedStyle values
and since no `column-rule-style` was set, we always returned 0. This looked
like passing because the
test normalizes the expected values by setting them to an element and running
getComputedStyle, which
was also always returning 0. To fix this test further, we will need to ensure
that pixel snapping
is also applied during interpolation (see
https://bugs.webkit.org/show_bug.cgi?id=304945).
* LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt:
*
LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
*
LayoutTests/fast/css/getComputedStyle/getComputedStyle-column-rule-expected.txt:
* LayoutTests/fast/css/getComputedStyle/getComputedStyle-column-rule.html:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-multicol/animation/column-rule-width-interpolation-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-multicol/parsing/column-rule-computed-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-multicol/parsing/column-rule-width-computed-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/column-rule-width-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/column-rule-width.html:
* LayoutTests/svg/css/getComputedStyle-basic-expected.txt:
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/rendering/BorderEdge.cpp:
* Source/WebCore/rendering/BorderEdge.h:
* Source/WebCore/rendering/RenderMultiColumnSet.cpp:
* Source/WebCore/rendering/style/BorderValue.cpp:
* Source/WebCore/rendering/style/BorderValue.h:
* Source/WebCore/rendering/style/CollapsedBorderValue.h:
* Source/WebCore/rendering/style/OutlineValue.cpp:
* Source/WebCore/rendering/style/OutlineValue.h:
* Source/WebCore/rendering/style/RenderStyle+GettersInlines.h:
* Source/WebCore/rendering/style/RenderStyle.cpp:
* Source/WebCore/rendering/style/RenderStyle.h:
* Source/WebCore/rendering/style/RenderStyleBase+GettersInlines.h:
* Source/WebCore/rendering/style/RenderStyleBase.h:
* Source/WebCore/rendering/style/RenderStyleConstants.h:
*
Source/WebCore/style/computed/StyleComputedStyleProperties+GettersCustomInlines.h:
* Source/WebCore/style/computed/data/StyleMultiColumnData.cpp:
* Source/WebCore/style/computed/data/StyleMultiColumnData.h:
* Source/WebCore/style/values/color/StyleColor.cpp:
* Source/WebCore/style/values/color/StyleColor.h:
Canonical link: https://commits.webkit.org/305240@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
