Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: b2e1c1159b0077c428d7f5c9e1db7fb062207639
https://github.com/WebKit/WebKit/commit/b2e1c1159b0077c428d7f5c9e1db7fb062207639
Author: Marcos Caceres <[email protected]>
Date: 2026-01-07 (Wed, 07 Jan 2026)
Changed paths:
A
LayoutTests/http/tests/digital-credentials/digital-credential-console-messages.https-expected.txt
A
LayoutTests/http/tests/digital-credentials/digital-credential-console-messages.https.html
A
LayoutTests/http/wpt/identity/digital-credential-protocol-filtering.https-expected.txt
A
LayoutTests/http/wpt/identity/digital-credential-protocol-filtering.https.html
M
LayoutTests/imported/w3c/web-platform-tests/digital-credentials/create.tentative.https.html
M
LayoutTests/imported/w3c/web-platform-tests/digital-credentials/get.tentative.https.html
M
LayoutTests/imported/w3c/web-platform-tests/digital-credentials/support/helper.js
M LayoutTests/platform/glib/TestExpectations
M LayoutTests/platform/ios-18/TestExpectations
M LayoutTests/platform/ios/TestExpectations
M
LayoutTests/platform/ios/imported/w3c/web-platform-tests/digital-credentials/get.tentative.https-expected.txt
M LayoutTests/platform/mac-sequoia/TestExpectations
M LayoutTests/platform/visionos/TestExpectations
M LayoutTests/platform/win/TestExpectations
M LayoutTests/platform/wpe/TestExpectations
M Source/WebCore/Modules/identity/DigitalCredential.cpp
M Source/WebCore/Modules/identity/DigitalCredentialRequest.h
M Source/WebCore/Modules/identity/DigitalCredentialRequest.idl
Log Message:
-----------
Digital Credentials: ignore unknown digital credential types
rdar://166673454
https://bugs.webkit.org/show_bug.cgi?id=304158
Reviewed by Anne van Kesteren.
WebKit relied on the IdentityCredentialProtocol.idl enum to prevent requests
with unknown protocols being processed.
However, this prevented unknown protocols from being ignored gracefully, as
required by this spec change:
https://github.com/w3c-fedid/digital-credentials/pull/372
We now gracefully ignore unknown protocols by filtering them out, rather than
throwing an error.
We also now show a console warning, so developers are aware of ignored
protocols.
Includes upstream web platform test commit:
https://github.com/web-platform-tests/wpt/commit/2d00123f9d72e0c18fa3110aec3893931b00c83b
Tests:
http/tests/digital-credentials/digital-credential-console-messages.https.html
http/wpt/identity/digital-credential-protocol-filtering.https.html
*
LayoutTests/http/tests/digital-credentials/digital-credential-console-messages.https-expected.txt:
Added.
*
LayoutTests/http/tests/digital-credentials/digital-credential-console-messages.https.html:
Added.
*
LayoutTests/http/wpt/identity/digital-credential-protocol-filtering.https-expected.txt:
Added.
*
LayoutTests/http/wpt/identity/digital-credential-protocol-filtering.https.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/digital-credentials/create.tentative.https.html:
*
LayoutTests/imported/w3c/web-platform-tests/digital-credentials/get.tentative.https.html:
*
LayoutTests/imported/w3c/web-platform-tests/digital-credentials/support/helper.js:
* LayoutTests/platform/glib/TestExpectations:
* LayoutTests/platform/ios-18/TestExpectations:
* LayoutTests/platform/ios/TestExpectations:
*
LayoutTests/platform/ios/imported/w3c/web-platform-tests/digital-credentials/get.tentative.https-expected.txt:
* LayoutTests/platform/mac-sequoia/TestExpectations:
* LayoutTests/platform/mac-wk1/TestExpectations:
* LayoutTests/platform/visionos/TestExpectations:
* LayoutTests/platform/win/TestExpectations:
* LayoutTests/platform/wpe/TestExpectations:
* Source/WebCore/Modules/identity/DigitalCredential.cpp:
(WebCore::convertProtocolString):
(WebCore::jsToCredentialRequest):
(WebCore::DigitalCredential::convertObjectsToDigitalPresentationRequests):
* Source/WebCore/Modules/identity/DigitalCredentialRequest.h:
* Source/WebCore/Modules/identity/DigitalCredentialRequest.idl:
Canonical link: https://commits.webkit.org/305257@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
