Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 0280081ab6aaac803e2d58bdb17802f602b1646f
https://github.com/WebKit/WebKit/commit/0280081ab6aaac803e2d58bdb17802f602b1646f
Author: Zak Ridouh <[email protected]>
Date: 2026-01-08 (Thu, 08 Jan 2026)
Changed paths:
M Tools/MiniBrowser/mac/AppDelegate.h
M Tools/MiniBrowser/mac/AppDelegate.m
M Tools/MiniBrowser/mac/BrowserWindow.xib
M Tools/MiniBrowser/mac/BrowserWindowController.m
M Tools/MiniBrowser/mac/MainMenu.xib
M Tools/MiniBrowser/mac/WK2BrowserWindowController.m
Log Message:
-----------
Add Cmd-T tab support to MiniBrowser with native macOS tabbing
https://bugs.webkit.org/show_bug.cgi?id=304998
rdar://167638810
Reviewed by Simon Fraser.
Currently, to enter into the multi-tab view creating a new window from
the menu bar, then "merging" windows.
Since the functionality is already there, wire up Cmd-T support, and use
the native macOS application tabbing behavior to make it less "awkward"
to add new tabs.
By using the native macOS tabbing behavior, we get a lot of functionality
"for free", such as:
- Cmd-T to create new tabs
- Window > Merge All Windows
- Window > Move Tab to New Window
- Dragging tabs between windows
In this patch,
- Added tabbingMode="preferred" to BrowserWindow.xib to enable native tab bar
- Added "New Tab" menu item (Cmd-T) to File menu
- Implement newTab: action that creates tabs inheriting the current
window's type (WK1/WK2) and configuration (private browsing, site isolation)
- Added tabbingIdentifier to group windows properly
- Use separate tabbingIdentifier for private windows to prevent merging
with regular windows
- Implemented newWindowForTab: delegate for the tab bar "+" button
* Tools/MiniBrowser/mac/AppDelegate.h:
* Tools/MiniBrowser/mac/AppDelegate.m:
(-[BrowserAppDelegate newTab:]):
* Tools/MiniBrowser/mac/BrowserWindow.xib:
* Tools/MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController windowDidLoad]):
(-[BrowserWindowController newWindowForTab:]):
* Tools/MiniBrowser/mac/MainMenu.xib:
* Tools/MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController dealloc]):
(-[WK2BrowserWindowController windowDidLoad]):
Canonical link: https://commits.webkit.org/305262@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
