Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: fd984eb67bc80f4134925d5a5a1345c8feb9e856
https://github.com/WebKit/WebKit/commit/fd984eb67bc80f4134925d5a5a1345c8feb9e856
Author: David Kilzer <[email protected]>
Date: 2026-01-08 (Thu, 08 Jan 2026)
Changed paths:
M
Source/WebKit/UIProcess/API/Cocoa/_WKAuthenticationExtensionsClientInputs.mm
M Source/WebKit/UIProcess/Cocoa/_WKCaptionStyleMenuController.h
M Source/WebKit/UIProcess/Cocoa/_WKCaptionStyleMenuControllerInternal.h
M Source/WebKit/UIProcess/mac/_WKCaptionStyleMenuControllerMac.mm
Log Message:
-----------
Fix Objective-C leaks caused by missing -dealloc and missing -release
<https://bugs.webkit.org/show_bug.cgi?id=304645>
<rdar://167089343>
Reviewed by Ryosuke Niwa.
* Source/WebKit/UIProcess/API/Cocoa/_WKAuthenticationExtensionsClientInputs.mm:
(-[_WKAuthenticationExtensionsClientInputs dealloc]):
- Release remaining three instance variables to fix leaks.
* Source/WebKit/UIProcess/Cocoa/_WKCaptionStyleMenuController.h:
(_WKCaptionStyleMenuController.delegate):
- Make delegate property nullable.
* Source/WebKit/UIProcess/Cocoa/_WKCaptionStyleMenuControllerInternal.h:
(_WKCaptionStyleMenuController.menu):
(_WKCaptionStyleMenuController.interaction):
- Make nullable so they may be released in -dealloc.
* Source/WebKit/UIProcess/mac/_WKCaptionStyleMenuControllerMac.mm:
(-[WKCaptionStyleMenuController dealloc]):
- Clear _delegate and release _savedActiveProfileID, _menu and
_interaction instance variables to match ARC behavior.
Canonical link: https://commits.webkit.org/305337@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
