Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: fe5cd6025f8db6b36239dffd9e588fb2ecfbdc6c
https://github.com/WebKit/WebKit/commit/fe5cd6025f8db6b36239dffd9e588fb2ecfbdc6c
Author: Tyler Wilcock <[email protected]>
Date: 2026-01-09 (Fri, 09 Jan 2026)
Changed paths:
A LayoutTests/accessibility/attributed-string-text-stitching-expected.txt
A LayoutTests/accessibility/attributed-string-text-stitching.html
M LayoutTests/platform/glib/TestExpectations
M LayoutTests/platform/ios/TestExpectations
A
LayoutTests/platform/ios/accessibility/attributed-string-text-stitching-expected.txt
M LayoutTests/resources/accessibility-helper.js
M Source/WebCore/accessibility/AXCoreObject.cpp
M Source/WebCore/accessibility/AXCoreObject.h
M Source/WebCore/accessibility/AccessibilityNodeObject.cpp
M Source/WebCore/accessibility/AccessibilityObject.cpp
M Source/WebCore/accessibility/AccessibilityRenderObject.cpp
M Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm
M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp
M Source/WebCore/accessibility/isolatedtree/mac/AXIsolatedObjectMac.mm
M Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm
Log Message:
-----------
AX: When the text marker range is requested from a stitched-text object, we
should return a range encompassing all objects within the stitch group
https://bugs.webkit.org/show_bug.cgi?id=305076
rdar://167721981
Reviewed by Joshua Hoffman.
With this commit, when an object has other objects stitched into it, its text
marker range will properly encompass all
objects within the stitch group. This is especially important for computing the
correct attributed strings, which are
retrieved using text markers.
Test: accessibility/attributed-string-text-stitching.html
* LayoutTests/accessibility/attributed-string-text-stitching-expected.txt:
Added.
* LayoutTests/accessibility/attributed-string-text-stitching.html: Added.
* LayoutTests/platform/glib/TestExpectations: Skip new test.
* LayoutTests/platform/ios/TestExpectations: Enable new test.
*
LayoutTests/platform/ios/accessibility/attributed-string-text-stitching-expected.txt:
Added.
* LayoutTests/resources/accessibility-helper.js:
* Source/WebCore/accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::simpleRange const):
* Source/WebCore/accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::boundingBoxRect const):
* Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper
_attributedStringForTextMarkerRangeForTesting:]):
* Source/WebCore/accessibility/isolatedtree/mac/AXIsolatedObjectMac.mm:
(WebCore::AXIsolatedObject::textMarkerRange const):
* Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
(WTR::AccessibilityUIElement::attributedStringForTextMarkerRange):
Canonical link: https://commits.webkit.org/305360@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
