Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7727ce4feadd3857aac4e76129740af5cbc66211
      
https://github.com/WebKit/WebKit/commit/7727ce4feadd3857aac4e76129740af5cbc66211
  Author: Alan Baradlay <[email protected]>
  Date:   2026-01-09 (Fri, 09 Jan 2026)

  Changed paths:
    M 
LayoutTests/imported/w3c/web-platform-tests/css/CSS2/normal-flow/block-replaced-height-002-expected.xht
    M 
LayoutTests/imported/w3c/web-platform-tests/css/CSS2/normal-flow/block-replaced-height-002.xht
    M 
LayoutTests/imported/w3c/web-platform-tests/css/CSS2/normal-flow/inline-block-replaced-height-002-expected.xht
    M 
LayoutTests/imported/w3c/web-platform-tests/css/CSS2/normal-flow/inline-block-replaced-height-002.xht
    M 
LayoutTests/imported/w3c/web-platform-tests/css/CSS2/normal-flow/inline-replaced-height-002-expected.xht
    M 
LayoutTests/imported/w3c/web-platform-tests/css/CSS2/normal-flow/inline-replaced-height-002.xht

  Log Message:
  -----------
  [subpixel-inline-layout] Test cases rely on specific default font metrics 
(part1)
https://bugs.webkit.org/show_bug.cgi?id=305212

Reviewed by Simon Fraser.

These test cases expect the 15px tall image to sit on the baseline and 
positioned at 0px in block direction inside the block container.
This works fine on macOS with default font metrics of 14/4 (ascent/descent) and 
0px line gap. The 15px tall image would stretch the
line box (root inline box is only 14px tall) and positioned at 0px (-1px from 
the top of the root inline box).

However on iOS we've got a slightly different font metric values of 15/4 and 
1px as line gap. Such setup introduces a 0.5px half leading
pushing the image to 0.5px in block direction.

Let's fix this ambiguity by using Ahem.

* 
LayoutTests/imported/w3c/web-platform-tests/css/CSS2/normal-flow/block-replaced-height-002-expected.xht:
* 
LayoutTests/imported/w3c/web-platform-tests/css/CSS2/normal-flow/block-replaced-height-002.xht:
* 
LayoutTests/imported/w3c/web-platform-tests/css/CSS2/normal-flow/inline-block-replaced-height-002-expected.xht:
* 
LayoutTests/imported/w3c/web-platform-tests/css/CSS2/normal-flow/inline-block-replaced-height-002.xht:
* 
LayoutTests/imported/w3c/web-platform-tests/css/CSS2/normal-flow/inline-replaced-height-002-expected.xht:
* 
LayoutTests/imported/w3c/web-platform-tests/css/CSS2/normal-flow/inline-replaced-height-002.xht:

Canonical link: https://commits.webkit.org/305375@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications

Reply via email to