Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ee8c90c7dd8337e0e936c8591eb599ef3a18409a
https://github.com/WebKit/WebKit/commit/ee8c90c7dd8337e0e936c8591eb599ef3a18409a
Author: Anne van Kesteren <[email protected]>
Date: 2026-01-11 (Sun, 11 Jan 2026)
Changed paths:
M Source/WebCore/Modules/indexeddb/IDBVersionChangeEvent.h
M Source/WebCore/Modules/speech/SpeechSynthesisErrorEvent.h
M Source/WebCore/animation/CSSAnimation.h
M Source/WebCore/dom/BeforeTextInsertedEvent.h
M Source/WebCore/dom/CompositionEvent.h
M Source/WebCore/dom/DeviceMotionClient.h
M Source/WebCore/dom/ErrorEvent.h
M Source/WebCore/dom/PointerEvent.h
M Source/WebCore/dom/TemplateContentDocumentFragment.h
M Source/WebCore/dom/TextEvent.h
M Source/WebCore/dom/TouchEvent.cpp
M Source/WebCore/dom/TouchEvent.h
M Source/WebCore/fileapi/File.h
M Source/WebCore/html/CustomPaintImage.h
M Source/WebCore/html/HTMLTablePartElement.h
Log Message:
-----------
Properly implement TYPE_TRAITS for SpeechSynthesisErrorEvent
https://bugs.webkit.org/show_bug.cgi?id=305306
Reviewed by Chris Dumez.
Normally event class wrappers are created through
EventFactory::toJSNewlyCreated(Ref<Event>&&) which uses interfaceType()
instead of the TYPE_TRAITS mechanism.
However, there's another code path generated by the bindings for
subclasses if there's no longer a cached wrapper which is why
SpeechSynthesisErrorEvent needs TYPE_TRAITS. I could not figure out
with Claude AI how to test that code path however, but it seems better
if it ends up doing the correct thing.
I discovered this while making more of the TYPE_TRAITS isX() methods
private and final, which explains the other changes made here.
Canonical link: https://commits.webkit.org/305441@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
