Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4071de80710d3445bd339ce94da6dc73f3022206
      
https://github.com/WebKit/WebKit/commit/4071de80710d3445bd339ce94da6dc73f3022206
  Author: Philippe Normand <[email protected]>
  Date:   2026-01-12 (Mon, 12 Jan 2026)

  Changed paths:
    M 
Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp

  Log Message:
  -----------
  [GStreamer][MediaStream] Clean internal mediastreamsrc sources only during 
actual disposal
https://bugs.webkit.org/show_bug.cgi?id=305257

Reviewed by Xabier Rodriguez-Calvar.

Clearing the internal sources right after EOS can lead to unsafe usage of the 
underlying appsrc
elements which haven't been stopped yet. So on EOS, post an empty stream 
collection without
releasing the sources just yet. They are released when the mediastreamsrc 
element is disposed.

* Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:
(webkitMediaStreamSrcCreateStreamCollection):
(webkitMediaStreamSrcEnsureStreamCollectionPosted):
(webkitMediaStreamSrcSignalEndOfStream):

Canonical link: https://commits.webkit.org/305452@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications

Reply via email to