Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 957351991fb188e33f1e5c49671ae7819ad8937f
https://github.com/WebKit/WebKit/commit/957351991fb188e33f1e5c49671ae7819ad8937f
Author: Anthony Tarbinian <[email protected]>
Date: 2026-01-12 (Mon, 12 Jan 2026)
Changed paths:
M Source/WebKit/UIProcess/BrowsingContextGroup.cpp
M Source/WebKit/UIProcess/BrowsingContextGroup.h
M Source/WebKit/UIProcess/FrameProcess.cpp
M Source/WebKit/UIProcess/FrameProcess.h
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm
Log Message:
-----------
[Site Isolation] Fix TestWebKitAPI.SiteIsolation.OpenBeforeInitialLoad
https://bugs.webkit.org/show_bug.cgi?id=300844
https://rdar.apple.com/162728352
Reviewed by Sihui Liu.
When navigation re-uses the source process and navigation is
going to a site which is different than the process's previous
site, don't inject browsing context into the process.
A similar call to ensureProcessForSite existed in
WebPageProxy::didCommitLoadForFrame. This is now moved to occur
in continueWithProcessForNavigation.
This patch also adds
BrowsingContextGroup::addFrameProcessWithoutInjectingPageContext
which updates BrowsingContextGroup's site -> process map even when
we don't want to inject browsing context into the process.
Also changes BrowsingContextGroup::InjectBrowsingContextIntoProcess to
BrowsingContextGroupUpdate which describes the following cases:
- None: don't modify BrowsingContextGroup
- AddProcess: only update m_processMap with the site->process mapping
- AddProcessAndInjectBrowsingContext: do the same as AddProcess
but also inject browsing context
Fixes API test SiteIsolation.OpenBeforeInitialLoad.
Test: Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm
* Source/WebKit/UIProcess/BrowsingContextGroup.cpp:
(WebKit::BrowsingContextGroup::sharedProcessForSite):
(WebKit::BrowsingContextGroup::ensureProcessForSite):
(WebKit::BrowsingContextGroup::addFrameProcessAndInjectPageContextIf):
(WebKit::BrowsingContextGroup::addFrameProcessWithoutInjectingPageContext):
* Source/WebKit/UIProcess/BrowsingContextGroup.h:
* Source/WebKit/UIProcess/FrameProcess.cpp:
(WebKit::FrameProcess::FrameProcess):
* Source/WebKit/UIProcess/FrameProcess.h:
(WebKit::FrameProcess::create):
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::receivedNavigationActionPolicyDecision):
(WebKit::WebPageProxy::continueNavigationInNewProcess):
(WebKit::WebPageProxy::didCommitLoadForFrame):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm:
(TestWebKitAPI::TEST(SiteIsolation, OpenBeforeInitialLoad)):
Canonical link: https://commits.webkit.org/305486@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
