Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: bcec4c977d56eb259596a3e654f318f8a23eb90a
https://github.com/WebKit/WebKit/commit/bcec4c977d56eb259596a3e654f318f8a23eb90a
Author: Matthew Finkel <[email protected]>
Date: 2026-01-14 (Wed, 14 Jan 2026)
Changed paths:
M Source/WebCore/loader/FrameLoader.cpp
M Source/WebCore/loader/FrameLoader.h
M Source/WebCore/loader/FrameLoaderTypes.h
M Source/WebCore/loader/cache/CachedResourceLoader.cpp
M Source/WebKit/Shared/LoadParameters.serialization.in
M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
M Source/WebKit/UIProcess/WebPageProxy.h
M Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.h
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
M Tools/TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm
Log Message:
-----------
HTTP Navigation attempts upgrade to HTTPS after recovery
https://bugs.webkit.org/show_bug.cgi?id=305028
rdar://154049670
Reviewed by Alex Christensen.
Currently, when we are recovering from a web process crash, or restoring state,
we always attempt an upgrade - even if the page that we are
recovering/restoring was loaded with HTTP after fallback.
This patch changes the behavior so we look at the back-forward list and
directly load using http is the entry's URL was http:. We bypass the upgrade
logic by introducing a new Disabled state in NavigationUpgradeToHTTPSBehavior.
Test: Tools/TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm
* Source/WebCore/loader/FrameLoader.cpp:
(WebCore::FrameLoader::checkLoadCompleteForThisFrame):
(WebCore::FrameLoader::shouldNavigateWithHTTP const):
* Source/WebCore/loader/FrameLoader.h:
* Source/WebCore/loader/FrameLoaderTypes.h:
* Source/WebCore/loader/cache/CachedResourceLoader.cpp:
(WebCore::shouldPerformHTTPSUpgrade):
(WebCore::CachedResourceLoader::requestResource):
* Source/WebKit/Shared/LoadParameters.serialization.in:
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::goToBackForwardItem):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
(TEST(WKNavigation,
PreferredHTTPSPolicyAutomaticHTTPFallbackAfterTerminateProcess)):
(TEST(WKNavigation,
PreferredHTTPSPolicyAutomaticHTTPFallbackAfterSessionRestore)):
Canonical link: https://commits.webkit.org/305609@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
