Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 89ad6512372ce162a068b05dda1b90e7b9e54d94
https://github.com/WebKit/WebKit/commit/89ad6512372ce162a068b05dda1b90e7b9e54d94
Author: Anne van Kesteren <[email protected]>
Date: 2026-01-20 (Tue, 20 Jan 2026)
Changed paths:
M
Source/WebCore/SaferCPPExpectations/NoUncheckedPtrMemberCheckerExpectations
M Source/WebCore/SaferCPPExpectations/UncheckedCallArgsCheckerExpectations
M Source/WebCore/SaferCPPExpectations/UncheckedLocalVarsCheckerExpectations
M Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
M Source/WebCore/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations
M Source/WebCore/css/query/ContainerQueryFeatures.cpp
M Source/WebCore/css/query/MediaQueryEvaluator.cpp
M Source/WebCore/css/query/MediaQueryEvaluator.h
M Source/WebCore/css/query/MediaQueryFeatures.cpp
M Source/WebCore/style/StyleResolver.h
Log Message:
-----------
Reduce unsafeness in WebCore/css/query
https://bugs.webkit.org/show_bug.cgi?id=304399
rdar://167168414
Reviewed by Chris Dumez.
Now that MediaQueryEvaluator holds m_rootElementStyle in a CheckedPtr,
we have to change the member order in StyleResolver such that
m_mediaQueryEvaluator gets deleted before m_rootDefaultStyle. Otherwise
the MediaQueryEvaluator destructor will throw.
Thanks to Claude AI for the fix.
Apply https://github.com/WebKit/WebKit/wiki/Safer-CPP-Guidelines
Canonical link: https://commits.webkit.org/305863@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
