Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 19207091a2dd307367a44abf1ce6bf7b711acbe2
https://github.com/WebKit/WebKit/commit/19207091a2dd307367a44abf1ce6bf7b711acbe2
Author: Sihui Liu <[email protected]>
Date: 2026-01-20 (Tue, 20 Jan 2026)
Changed paths:
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
Log Message:
-----------
[Site Isolation] Fix crash in
imported/w3c/web-platform-tests/html/cross-origin-opener-policy/iframe-popup-same-origin-allow-popups-to-same-origin-allow-popups.https.html
https://bugs.webkit.org/show_bug.cgi?id=305800
rdar://168472141
Reviewed by Alex Christensen.
Ensure to also stop loading in provisional frame when page is closed, so that
the rendering and layout of that frame
will be stopped and frame can be destroyed -- FrameLoader::detachFromParent()
does a bunch of necessary cleanup, like
setting LocalFrame::m_view to null to break reference cycle of LocalFrame and
LocalFrameView. Otherwise, the rendering
code would keep running with assumption that page is still alive; and we will
see the crash as in the bug report.
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::close):
Canonical link: https://commits.webkit.org/305891@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications