Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 1b5be313fba999a28ae17b00cd5a234ce1c773e3
https://github.com/WebKit/WebKit/commit/1b5be313fba999a28ae17b00cd5a234ce1c773e3
Author: Alex Christensen <[email protected]>
Date: 2026-01-20 (Tue, 20 Jan 2026)
Changed paths:
M Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h
M Source/WebKit/UIProcess/Cocoa/UIDelegate.h
M Source/WebKit/UIProcess/Cocoa/UIDelegate.mm
M Tools/TestWebKitAPI/SourcesCocoa.txt
M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
A Tools/TestWebKitAPI/Tests/WebKitCocoa/FocusWebView.mm
A Tools/TestWebKitAPI/Tests/WebKitCocoa/open-in-new-tab.html
R Tools/TestWebKitAPI/Tests/mac/FocusWebView.mm
R Tools/TestWebKitAPI/Tests/mac/open-in-new-tab.html
M Tools/TestWebKitAPI/cocoa/TestUIDelegate.mm
M Tools/TestWebKitAPI/cocoa/TestWKWebView.h
M Tools/TestWebKitAPI/cocoa/TestWKWebView.mm
Log Message:
-----------
Improve focus testing on iOS
https://bugs.webkit.org/show_bug.cgi?id=305616
rdar://168269229
Reviewed by Brady Eidson.
There were a few pieces of test infrastructure that weren't hooked up on iOS
for some odd reason, even though they work fine on iOS. The only part of this
PR that is somewhat substantial is the implementation of
TestWKWebView.typeCharacter
which I implemented in a simple way that is good enough for these tests.
I leave
FocusWebView.CrossOriginIframeRelinquishToChromeTests.Test/siteIsolation_is_enabled
on iOS to a future PR. It still doesn't work for a more involved reason that
needs more investigation.
Tests: Tools/TestWebKitAPI/SourcesCocoa.txt
Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
Tools/TestWebKitAPI/Tests/WebKitCocoa/FocusWebView.mm
Tools/TestWebKitAPI/Tests/WebKitCocoa/open-in-new-tab.html
Tools/TestWebKitAPI/cocoa/TestUIDelegate.mm
Tools/TestWebKitAPI/cocoa/TestWKWebView.h
Tools/TestWebKitAPI/cocoa/TestWKWebView.mm
* Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
* Source/WebKit/UIProcess/Cocoa/UIDelegate.h:
* Source/WebKit/UIProcess/Cocoa/UIDelegate.mm:
(WebKit::UIDelegate::setDelegate):
(WebKit::UIDelegate::UIClient::focus):
(WebKit::UIDelegate::UIClient::unfocus):
* Tools/TestWebKitAPI/SourcesCocoa.txt:
* Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/FocusWebView.mm: Renamed from
Tools/TestWebKitAPI/Tests/mac/FocusWebView.mm.
(TestWebKitAPI::AdvanceFocusRelinquishToChrome)):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/open-in-new-tab.html: Renamed from
Tools/TestWebKitAPI/Tests/mac/open-in-new-tab.html.
* Tools/TestWebKitAPI/cocoa/TestUIDelegate.mm:
(-[TestUIDelegate _webView:takeFocus:]):
(-[TestUIDelegate _focusWebView:]):
(-[TestUIDelegate _unfocusWebView:]):
* Tools/TestWebKitAPI/cocoa/TestWKWebView.h:
* Tools/TestWebKitAPI/cocoa/TestWKWebView.mm:
(-[TestWKWebView typeCharacter:]):
Canonical link: https://commits.webkit.org/305906@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
