Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: cf9cd69e0cb71aeecaf6655d67e88440bafc1e28
https://github.com/WebKit/WebKit/commit/cf9cd69e0cb71aeecaf6655d67e88440bafc1e28
Author: Megan Gardner <[email protected]>
Date: 2026-01-20 (Tue, 20 Jan 2026)
Changed paths:
M Source/WebCore/html/HTMLSelectElement.h
M Source/WebCore/html/SearchInputType.h
M Source/WebCore/platform/PopupMenuClient.h
M Source/WebKit/WebProcess/WebCoreSupport/WebPopupMenu.cpp
M Source/WebKit/WebProcess/WebCoreSupport/WebPopupMenu.h
M Source/WebKit/WebProcess/WebCoreSupport/mac/WebPopupMenuMac.mm
M Source/WebKitLegacy/mac/WebCoreSupport/PopupMenuMac.h
M Source/WebKitLegacy/mac/WebCoreSupport/PopupMenuMac.mm
Log Message:
-----------
Final step in fixing crash in WebKit::WebPopupMenu::didChangeSelectedIndex.
https://bugs.webkit.org/show_bug.cgi?id=305681
rdar://162142276
Reviewed by Wenson Hsieh.
After the refactors in 305556@main and 305728@main
we are now able to make PopupMenuClient a
RefPtr instead of a CheckedPtr. This will allow
us to check if a PopupMenuClient exists, and move
on if it doesn't, instead of crashing.
* Source/WebCore/html/HTMLSelectElement.h:
* Source/WebCore/html/SearchInputType.h:
* Source/WebCore/platform/PopupMenuClient.h:
* Source/WebKit/WebProcess/WebCoreSupport/WebPopupMenu.cpp:
(WebKit::WebPopupMenu::didChangeSelectedIndex):
(WebKit::WebPopupMenu::setTextForIndex):
(WebKit::WebPopupMenu::populateItems):
(WebKit::WebPopupMenu::show):
(WebKit::WebPopupMenu::hide):
* Source/WebKit/WebProcess/WebCoreSupport/WebPopupMenu.h:
* Source/WebKit/WebProcess/WebCoreSupport/mac/WebPopupMenuMac.mm:
(WebKit::WebPopupMenu::setUpPlatformData):
* Source/WebKitLegacy/mac/WebCoreSupport/PopupMenuMac.h:
(PopupMenuMac::protectedClient const):
(PopupMenuMac::checkedClient const): Deleted.
* Source/WebKitLegacy/mac/WebCoreSupport/PopupMenuMac.mm:
(PopupMenuMac::populate):
(PopupMenuMac::show):
(PopupMenuMac::hide):
Canonical link: https://commits.webkit.org/305910@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
