Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 5d2512e62169eebc1906abe8284441ea8e741280
https://github.com/WebKit/WebKit/commit/5d2512e62169eebc1906abe8284441ea8e741280
Author: Ruthvik Konda <[email protected]>
Date: 2026-01-23 (Fri, 23 Jan 2026)
Changed paths:
M
LayoutTests/http/tests/security/mixedContent/data-url-iframe-in-main-frame-expected.txt
M
LayoutTests/http/tests/security/mixedContent/data-url-iframe-in-main-frame.html
M
LayoutTests/http/tests/security/mixedContent/insecure-css-in-main-frame-expected.txt
M
LayoutTests/http/tests/security/mixedContent/insecure-css-in-main-frame.html
M
LayoutTests/http/tests/security/mixedContent/insecure-css-with-secure-cookies-UpgradeMixedContent-expected.txt
M
LayoutTests/http/tests/security/mixedContent/insecure-css-with-secure-cookies-UpgradeMixedContent.html
M
LayoutTests/http/tests/security/mixedContent/insecure-executable-css-with-secure-cookies-UpgradeMixedContent-expected.txt
M
LayoutTests/http/tests/security/mixedContent/insecure-executable-css-with-secure-cookies-UpgradeMixedContent.html
M
LayoutTests/http/tests/security/mixedContent/resources/frame-with-insecure-css.html
R
LayoutTests/http/tests/site-isolation/mixedContent/data-url-iframe-in-main-frame-expected.txt
R
LayoutTests/http/tests/site-isolation/mixedContent/data-url-iframe-in-main-frame.html
M LayoutTests/platform/ios-site-isolation/TestExpectations
R
LayoutTests/platform/wk2/http/tests/security/mixedContent/data-url-iframe-in-main-frame-expected.txt
R
LayoutTests/platform/wk2/http/tests/security/mixedContent/insecure-css-in-main-frame-expected.txt
Log Message:
-----------
[Site Isolation] Fix iOS SI mixed content test failures
https://bugs.webkit.org/show_bug.cgi?id=305850
rdar://168513075
Reviewed by Sihui Liu.
Similar to 304243@main and 304370@main, these tests were failing due to frame
loading callback differences. With site isolation on, frame load order output
is indeterministic.
Fframe load callbacks are currently present because the tests were
written about a decade ago (for example,
https://commits.webkit.org/176539@main).
In the past, the frame load output was almost certainly used for debugging.
However today, the frame load callbacks do not contribute anything useful to
these tests and they should be removed.
The actual upgrade/block mechanism of mixed content is tested via the mixed
content violation console message in the expected.txt.
Since rdar://161348735 does not apply to css getting blocked, we use onload
instead of the settimeout workaround for
frame-with-insecure-css.html. This will fix the race condition for
insecure-css-in-main-frame where sometimes
the test would end via notifyDone() before the console message could be
propagated.
*
LayoutTests/http/tests/security/mixedContent/data-url-iframe-in-main-frame-expected.txt:
*
LayoutTests/http/tests/security/mixedContent/data-url-iframe-in-main-frame.html:
*
LayoutTests/http/tests/security/mixedContent/insecure-css-in-main-frame-expected.txt:
* LayoutTests/http/tests/security/mixedContent/insecure-css-in-main-frame.html:
*
LayoutTests/http/tests/security/mixedContent/insecure-css-with-secure-cookies-UpgradeMixedContent-expected.txt:
*
LayoutTests/http/tests/security/mixedContent/insecure-css-with-secure-cookies-UpgradeMixedContent.html:
*
LayoutTests/http/tests/security/mixedContent/insecure-executable-css-with-secure-cookies-UpgradeMixedContent-expected.txt:
*
LayoutTests/http/tests/security/mixedContent/insecure-executable-css-with-secure-cookies-UpgradeMixedContent.html:
*
LayoutTests/http/tests/security/mixedContent/resources/frame-with-insecure-css.html:
*
LayoutTests/http/tests/site-isolation/mixedContent/data-url-iframe-in-main-frame-expected.txt:
Removed.
*
LayoutTests/http/tests/site-isolation/mixedContent/data-url-iframe-in-main-frame.html:
Removed.
* LayoutTests/platform/ios-site-isolation/TestExpectations:
*
LayoutTests/platform/wk2/http/tests/security/mixedContent/data-url-iframe-in-main-frame-expected.txt:
Removed.
*
LayoutTests/platform/wk2/http/tests/security/mixedContent/insecure-css-in-main-frame-expected.txt:
Removed.
Canonical link: https://commits.webkit.org/306104@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
