Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: dcea00103e885d456ca2bf1fdf46f86a0c541a5d
https://github.com/WebKit/WebKit/commit/dcea00103e885d456ca2bf1fdf46f86a0c541a5d
Author: Claudio Saavedra <[email protected]>
Date: 2026-01-29 (Thu, 29 Jan 2026)
Changed paths:
A LayoutTests/animations/animation-crash-expected.txt
A LayoutTests/animations/animation-crash.html
M Source/WebCore/animation/KeyframeEffect.cpp
Log Message:
-----------
KeyframeEffect: reduce scope of checked pointer
https://bugs.webkit.org/show_bug.cgi?id=306445
Reviewed by Geoffrey Garen and Anne van Kesteren.
After 305794@main introduced smart pointers in KeyframeEffect,
it's possible to hit an assertion when the checked pointer in
forceLayoutIfNeeded() goes out of scope at the end of the function.
Since this variable is only needed briefly, it's better to reduce its
scope as later calls in that method might delete the underlying
renderer object.
Test: animations/animation-crash.html
* LayoutTests/animations/animation-crash-expected.txt: Added.
* LayoutTests/animations/animation-crash.html: Added.
* Source/WebCore/animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::forceLayoutIfNeeded):
Canonical link: https://commits.webkit.org/306401@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
