Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: c23bbc79d36d39af0b84d23c99009c64725d0fb0
https://github.com/WebKit/WebKit/commit/c23bbc79d36d39af0b84d23c99009c64725d0fb0
Author: Carlos Alberto Lopez Perez <[email protected]>
Date: 2026-01-30 (Fri, 30 Jan 2026)
Changed paths:
M Tools/CISupport/ews-build/steps.py
M Tools/CISupport/ews-build/steps_unittest.py
Log Message:
-----------
[WKCI][GLIB] WK2 EWS logic doesn't handle correctly the case when the step
layout-tests-repeat-failures (with patch) returns error with a list of flakes
but not a list of non-flaky failures.
https://bugs.webkit.org/show_bug.cgi?id=306477
Reviewed by Nikolas Zimmermann.
This is a follow-up to 306085@main. It seems there is stil an issue with the
logic when the step
layout-tests-repeat-failures (with patch) returns error and the list of
non-flaky failures is
empty but there is a list of flakes.
In 306367@main I tried to fix this on the runner by making it return a
non-error when there were
no non-flaky failures (only flakes) but that broke the step
"run-layout-tests-in-stress-mode",
so I reverted it.
This patch changes the EWS logic to deal with the case of non-zero exit code
(error) but there is
a list of flakes (even when there is not a list of non-flaky-failures). This is
in line with the
expectations that are coded in the step "run-layout-tests-in-stress-mode" where
it assumes that
an exit error code means that it generated a result with flakes.
* Tools/CISupport/ews-build/steps.py:
(AnalyzeLayoutTestsResultsRedTree.run):
* Tools/CISupport/ews-build/steps_unittest.py:
(TestAnalyzeLayoutTestsResultsRedTree.test_step_retry_with_change_error_with_flakies):
Canonical link: https://commits.webkit.org/306483@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
