Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: a3054e0f9369e1342d1e67d81f6cde44f1598198
https://github.com/WebKit/WebKit/commit/a3054e0f9369e1342d1e67d81f6cde44f1598198
Author: Chris Dumez <[email protected]>
Date: 2026-01-30 (Fri, 30 Jan 2026)
Changed paths:
M Source/WTF/WTF.xcodeproj/project.pbxproj
M Source/WTF/wtf/PlatformMac.cmake
M Source/WTF/wtf/RetainPtr.h
A Source/WTF/wtf/cf/CFTypeTraits.h
M Source/WTF/wtf/cf/TypeCastsCF.h
Log Message:
-----------
`protect()` overload for CF types is too permissive
https://bugs.webkit.org/show_bug.cgi?id=306615
Reviewed by Geoffrey Garen.
`protect()` overload for CF types is too permissive and can get called
for non-CFTypes. This is because `CFTypeRef` is a typedef to `void*`.
To address the issue, I am introduced a new `IsCFType` (Similar to the
existing `IsNSType`) which matches CFTypes based on whether or not
CFTypeTrait exists for the type.
* Source/WTF/WTF.xcodeproj/project.pbxproj:
* Source/WTF/wtf/PlatformMac.cmake:
* Source/WTF/wtf/RetainPtr.h:
* Source/WTF/wtf/cf/CFTypeTraits.h: Copied from Source/WTF/wtf/cf/TypeCastsCF.h.
* Source/WTF/wtf/cf/TypeCastsCF.h:
Canonical link: https://commits.webkit.org/306493@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications