Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 1dfd460b7bf9c9c9b4ac07c82f19eb47040a5e43
https://github.com/WebKit/WebKit/commit/1dfd460b7bf9c9c9b4ac07c82f19eb47040a5e43
Author: Ben Nham <[email protected]>
Date: 2026-01-30 (Fri, 30 Jan 2026)
Changed paths:
M Source/WebCore/page/ProcessWarming.cpp
M Source/WebKit/WebProcess/WebProcess.cpp
Log Message:
-----------
Add defaultLanguage to list of preheated functions
https://bugs.webkit.org/show_bug.cgi?id=306599
rdar://169017664
Reviewed by Per Arne Vollan.
I was assigned a JetStream regression caused by not using the injected bundle.
The first iteration
of a particular subtest was a couple of milliseconds slower, which had a small
but consistently
measurable impact on the overall benchmark score.
The first regression was slower due to faulting in code and data related to
computing the user's
default language. Previously, the injected bundle happened to do this as a side
effect of its
initialization. When we run without the injected bundle, that side effect
wasn't happening anymore,
so instead we were paying for the faults and computation in the middle of the
benchmark.
To fix this, add defaultLanguage to the list of functions in prewarmGlobally.
Unfortunately even that is not quite enough to appease the benchmark runner, as
it runs in a
non-prewarmed WebProcess. So we additionally call defaultLanguage shortly after
process
initialization in non-prewarmed processes.
* Source/WebCore/page/ProcessWarming.cpp:
(WebCore::ProcessWarming::prewarmGlobally):
* Source/WebKit/WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):
Canonical link: https://commits.webkit.org/306496@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
