Title: [114093] trunk/Source/WebCore
- Revision
- 114093
- Author
- aba...@webkit.org
- Date
- 2012-04-13 00:53:46 -0700 (Fri, 13 Apr 2012)
Log Message
Prepare submitForm for seamless navigation
https://bugs.webkit.org/show_bug.cgi?id=83838
Reviewed by Ryosuke Niwa.
Previously, FrameLoader::submitForm called FrameTree::find and
Document::canNavigate separately. This patch refactors this function
to call findFrameForNavigation, which does both checks.
This doesn't change any behavior today, but it prepares us to implement
seamless navigation. Once the seamless branch lands, this change will
be tested by seamless-form-* in https://github.com/eseidel/webkit/tree/seamless/LayoutTests/fast/frames/seamless
For context, see:
https://github.com/eseidel/webkit/commit/3f27340577ac91b2cc0a834dd2c6fdfcac296c32
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::submitForm):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (114092 => 114093)
--- trunk/Source/WebCore/ChangeLog 2012-04-13 07:35:40 UTC (rev 114092)
+++ trunk/Source/WebCore/ChangeLog 2012-04-13 07:53:46 UTC (rev 114093)
@@ -1,3 +1,24 @@
+2012-04-13 Adam Barth <aba...@webkit.org>
+
+ Prepare submitForm for seamless navigation
+ https://bugs.webkit.org/show_bug.cgi?id=83838
+
+ Reviewed by Ryosuke Niwa.
+
+ Previously, FrameLoader::submitForm called FrameTree::find and
+ Document::canNavigate separately. This patch refactors this function
+ to call findFrameForNavigation, which does both checks.
+
+ This doesn't change any behavior today, but it prepares us to implement
+ seamless navigation. Once the seamless branch lands, this change will
+ be tested by seamless-form-* in https://github.com/eseidel/webkit/tree/seamless/LayoutTests/fast/frames/seamless
+
+ For context, see:
+ https://github.com/eseidel/webkit/commit/3f27340577ac91b2cc0a834dd2c6fdfcac296c32
+
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::submitForm):
+
2012-04-13 Kent Tamura <tk...@chromium.org>
Should clear an invalid string in a date field on blur
Modified: trunk/Source/WebCore/loader/FrameLoader.cpp (114092 => 114093)
--- trunk/Source/WebCore/loader/FrameLoader.cpp 2012-04-13 07:35:40 UTC (rev 114092)
+++ trunk/Source/WebCore/loader/FrameLoader.cpp 2012-04-13 07:53:46 UTC (rev 114093)
@@ -310,9 +310,7 @@
return;
}
- Frame* targetFrame = m_frame->tree()->find(submission->target());
- if (!submission->state()->sourceDocument()->canNavigate(targetFrame))
- return;
+ Frame* targetFrame = findFrameForNavigation(submission->target(), submission->state()->sourceDocument());
if (!targetFrame) {
if (!DOMWindow::allowPopUp(m_frame) && !ScriptController::processingUserGesture())
return;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
