Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 1cb7d5590c72d1e8f36f8945dd9458427c672760
https://github.com/WebKit/WebKit/commit/1cb7d5590c72d1e8f36f8945dd9458427c672760
Author: Sammy Gill <[email protected]>
Date: 2026-02-02 (Mon, 02 Feb 2026)
Changed paths:
M Source/WebCore/layout/formattingContexts/grid/GridLayout.cpp
M Source/WebCore/layout/formattingContexts/grid/GridLayout.h
Log Message:
-----------
[GFC] Move grid area sizes computation out of layoutGridItems
https://bugs.webkit.org/show_bug.cgi?id=306682
rdar://169331635
Reviewed by Brandon Stewart.
We currently compute the grid area size for each grid item by checking
the columns/rows it spans, summing those track sizes, and including any
gutters it spans. We do this in layoutGridItems right now since we need
to know the containing block size when doing the final layout of the
grid items.
However, we will need these same dimensions for the purposes of
alignment. So in this patch we do a bit of refactoring by moving this
computation out of layoutGridItems and just passing the grid area sizes
in. We can then pass in these same sizes to the alignment code so that
we can use them when we implement alignment values that require them.
Canonical link: https://commits.webkit.org/306646@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
