Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 8b2484152e387bd4c6c3ef30cc1d34879e349433
https://github.com/WebKit/WebKit/commit/8b2484152e387bd4c6c3ef30cc1d34879e349433
Author: Carlos Garcia Campos <[email protected]>
Date: 2026-02-03 (Tue, 03 Feb 2026)
Changed paths:
M Source/WebCore/platform/graphics/ShareableBitmap.h
M Source/WebCore/platform/graphics/skia/PlatformDisplaySkia.cpp
M Source/WebCore/platform/graphics/skia/ShareableBitmapSkia.cpp
M
Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/AcceleratedSurface.cpp
M Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/AcceleratedSurface.h
M
Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/NonCompositedFrameRenderer.cpp
Log Message:
-----------
[GTK][WPE] Non composited renderer doesn't work on HiDPI screens
https://bugs.webkit.org/show_bug.cgi?id=306851
Reviewed by Nikolas Zimmermann and Miguel Gomez.
The non composited renderer is not applying the device scale factor.
This patch changes the way we render the frame to be similar to what we
do when rendering the tiles. So, instead of getting a GraphicsContext
from the AcceleratedSurface to render the page into, we get a SkCanvas
so that we can create a GraphicsContext and apply the device scale
factor there. We also ensure that the skia gl context is current before
destroying the GrContext to ensure gl resources are properly released.
* Source/WebCore/platform/graphics/ShareableBitmap.h:
* Source/WebCore/platform/graphics/skia/PlatformDisplaySkia.cpp:
(WebCore::SkiaGLContext::~SkiaGLContext):
* Source/WebCore/platform/graphics/skia/ShareableBitmapSkia.cpp:
(WebCore::ShareableBitmap::createSurface):
(WebCore::ShareableBitmap::createGraphicsContext):
* Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/AcceleratedSurface.cpp:
(WebKit::AcceleratedSurface::RenderTargetShareableBuffer::skiaSurface):
(WebKit::AcceleratedSurface::RenderTargetShareableBuffer::sync):
(WebKit::AcceleratedSurface::RenderTargetSHMImageWithoutGL::skiaSurface):
(WebKit::AcceleratedSurface::canvas):
(WebKit::AcceleratedSurface::RenderTargetShareableBuffer::graphicsContext):
Deleted.
(WebKit::AcceleratedSurface::RenderTargetSHMImageWithoutGL::graphicsContext):
Deleted.
(WebKit::AcceleratedSurface::graphicsContext): Deleted.
* Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/AcceleratedSurface.h:
*
Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/NonCompositedFrameRenderer.cpp:
(WebKit::NonCompositedFrameRenderer::display):
Canonical link: https://commits.webkit.org/306709@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
