Title: [114124] trunk
- Revision
- 114124
- Author
- commit-qu...@webkit.org
- Date
- 2012-04-13 06:26:44 -0700 (Fri, 13 Apr 2012)
Log Message
Unreviewed, rolling out r113714.
http://trac.webkit.org/changeset/113714
https://bugs.webkit.org/show_bug.cgi?id=83887
It is behaving strange on the bots and needs more
investigation. (Requested by jeez_ on #webkit).
Patch by Sheriff Bot <webkit.review....@gmail.com> on 2012-04-13
Source/WebKit2:
* UIProcess/qt/QtPageClient.cpp:
(QtPageClient::isViewWindowActive):
Tools:
* WebKitTestRunner/qt/PlatformWebViewQt.cpp:
(WTR::PlatformWebView::PlatformWebView):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (114123 => 114124)
--- trunk/Source/WebKit2/ChangeLog 2012-04-13 13:16:58 UTC (rev 114123)
+++ trunk/Source/WebKit2/ChangeLog 2012-04-13 13:26:44 UTC (rev 114124)
@@ -1,3 +1,15 @@
+2012-04-13 Sheriff Bot <webkit.review....@gmail.com>
+
+ Unreviewed, rolling out r113714.
+ http://trac.webkit.org/changeset/113714
+ https://bugs.webkit.org/show_bug.cgi?id=83887
+
+ It is behaving strange on the bots and needs more
+ investigation. (Requested by jeez_ on #webkit).
+
+ * UIProcess/qt/QtPageClient.cpp:
+ (QtPageClient::isViewWindowActive):
+
2012-04-12 Jocelyn Turcotte <jocelyn.turco...@nokia.com>
[Qt] Use QQuickFlickable::setPixelAligned instead of doing pixel-alignment when rendering.
Modified: trunk/Source/WebKit2/UIProcess/qt/QtPageClient.cpp (114123 => 114124)
--- trunk/Source/WebKit2/UIProcess/qt/QtPageClient.cpp 2012-04-13 13:16:58 UTC (rev 114123)
+++ trunk/Source/WebKit2/UIProcess/qt/QtPageClient.cpp 2012-04-13 13:26:44 UTC (rev 114124)
@@ -256,9 +256,8 @@
bool QtPageClient::isViewWindowActive()
{
- if (!m_webView || !m_webView->canvas())
- return false;
- return m_webView->canvas()->isActive();
+ // FIXME: The scene graph does not have the concept of being active or not when this was written.
+ return true;
}
bool QtPageClient::isViewFocused()
Modified: trunk/Tools/ChangeLog (114123 => 114124)
--- trunk/Tools/ChangeLog 2012-04-13 13:16:58 UTC (rev 114123)
+++ trunk/Tools/ChangeLog 2012-04-13 13:26:44 UTC (rev 114124)
@@ -1,3 +1,15 @@
+2012-04-13 Sheriff Bot <webkit.review....@gmail.com>
+
+ Unreviewed, rolling out r113714.
+ http://trac.webkit.org/changeset/113714
+ https://bugs.webkit.org/show_bug.cgi?id=83887
+
+ It is behaving strange on the bots and needs more
+ investigation. (Requested by jeez_ on #webkit).
+
+ * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
+ (WTR::PlatformWebView::PlatformWebView):
+
2012-04-11 Jocelyn Turcotte <jocelyn.turco...@nokia.com>
webkit-tools-completion: Support bugzilla email completion for webkit-patch upload --cc
Modified: trunk/Tools/WebKitTestRunner/qt/PlatformWebViewQt.cpp (114123 => 114124)
--- trunk/Tools/WebKitTestRunner/qt/PlatformWebViewQt.cpp 2012-04-13 13:16:58 UTC (rev 114123)
+++ trunk/Tools/WebKitTestRunner/qt/PlatformWebViewQt.cpp 2012-04-13 13:26:44 UTC (rev 114124)
@@ -76,11 +76,6 @@
{
QQuickWebViewExperimental experimental(m_view);
experimental.setRenderToOffscreenBuffer(true);
-
- // QWindow delays creating of the underlying platform specific bits until ::setVisible()
- // or ::show() are called. This makes ::isActive() always return false. In order to force
- // the creation ::create() exists, so we use it here.
- m_window->create();
}
PlatformWebView::~PlatformWebView()
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
